Skip to content

Fix #842 - #843

Open
IMoHaMeDHaMdYI wants to merge 1 commit into
nickbutcher:mainfrom
IMoHaMeDHaMdYI:patch-1
Open

Fix #842#843
IMoHaMeDHaMdYI wants to merge 1 commit into
nickbutcher:mainfrom
IMoHaMeDHaMdYI:patch-1

Conversation

@IMoHaMeDHaMdYI

@IMoHaMeDHaMdYI IMoHaMeDHaMdYI commented Oct 11, 2020

Copy link
Copy Markdown

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Changed MutableList to CopyOnWriteArrayList to prevent ConcurrentModificationException

💡 Motivation and Context

I took this class as reference to create an animation to my lists, I had this problem and I wanted to help other people out if they are deciding to use this class in their apps

💚 How did you test it?

I had a case in this gif in the issue #842 and now it doesn't happen

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

📸 Screenshots / GIFs

Look at #842

@google-cla

google-cla Bot commented Oct 11, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Oct 11, 2020
@IMoHaMeDHaMdYI

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla

google-cla Bot commented Oct 11, 2020

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot removed the cla: no label Oct 11, 2020
@IMoHaMeDHaMdYI
IMoHaMeDHaMdYI changed the base branch from master to main October 11, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants