Skip to content

Subclassing improvements #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastianludwig wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Subclassing improvements #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff80cac
Exposed remindLater to be accessible for subclasses.
sebastianludwig Nov 3, 2015
9c20248
Returning instancetype from init to be consistent with sharedInstance.
sebastianludwig Nov 3, 2015
f36fdd9
Using id as sharedInstance type.
sebastianludwig Nov 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions iRate/iRate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ typedef NS_ENUM(NSUInteger, iRateErrorCode)
- (void)promptIfAllCriteriaMet;
- (void)openRatingsPageInAppStore;
- (void)logEvent:(BOOL)deferPrompt;
- (void)remindLater;

@end

Expand Down
6 changes: 3 additions & 3 deletions iRate/iRate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ + (void)load

+ (instancetype)sharedInstance
{
static iRate *sharedInstance = nil;
static id sharedInstance = nil;
if (sharedInstance == nil)
{
sharedInstance = [(iRate *)[self alloc] init];
sharedInstance = [[self alloc] init];
}
return sharedInstance;
}
Expand Down Expand Up @@ -161,7 +161,7 @@ - (NSString *)localizedStringForKey:(NSString *)key withDefault:(NSString *)defa
return [[NSBundle mainBundle] localizedStringForKey:key value:defaultString table:nil];
}

- (iRate *)init
- (instancetype)init
{
if ((self = [super init]))
{
Expand Down