Skip to content

Refactor duplicated runtime paths and remove AI code slop - #27

Merged
nicknad merged 1 commit into
mainfrom
refactor/untangle-and-remove-ai-slop
Nov 8, 2026
Merged

nicknad merged 1 commit into
mainfrom
refactor/untangle-and-remove-ai-slop

Conversation

@nicknad

@nicknad nicknad commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Consolidated producer/consumer session runtime (run loop, peer wait, progress/cancellation, notification wait/signal) into SessionRuntime.
  • Consolidated the four hosted services onto SparcHostedServiceRunner and shared DI registration helpers.
  • Extracted shared CLI option parsing/validation/session helpers and removed duplicate Producer/Consumer wiring.
  • Unified slot framing, defaults, capacity constants, timeout test helpers, and shared test region names.
  • Removed dead code, stale comments, redundant defensive checks, and weak/tautological tests.
  • Fixed: infinite peer timeout, channel endpoint leak on failed open, InMemory pin race, Unix partial-file cleanup, Windows capability view ownership, analyzer named-argument/default-null handling, and fuzz generators that never exercised success paths.

Tests

  • dotnet build Sparc.slnx -c Release --no-incremental (0 warnings/errors)
  • dotnet test Sparc.slnx -c Release --no-build (270 passed, 9 Windows-only skipped, 0 failed)
  • dotnet build Sparc.Samples.slnx -c Release --no-incremental

- Share session run/wait/notification logic between producer and consumer
- Share hosted-service pipeline and CLI option parsing
- Unify slot framing, defaults, and test helpers
- Remove dead code, stale comments, and redundant checks
- Fix channel endpoint leaks, pin race, capability ownership, and analyzer argument matching
@nicknad
nicknad merged commit 552c97c into main Nov 8, 2026
2 checks passed
@nicknad
nicknad deleted the refactor/untangle-and-remove-ai-slop branch November 11, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant