fixes 25826; var type class parameter matches lvalues#25827
Open
demotomohiro wants to merge 1 commit into
Open
fixes 25826; var type class parameter matches lvalues#25827demotomohiro wants to merge 1 commit into
demotomohiro wants to merge 1 commit into
Conversation
Araq
reviewed
May 29, 2026
| @@ -0,0 +1,23 @@ | |||
| # issue #25826 | |||
|
|
|||
| proc foo(x: var) = x = 123 | |||
Member
There was a problem hiding this comment.
I don't remember the part of my spec that says "you can write var without any type at all"...
Contributor
Author
There was a problem hiding this comment.
var type class is listed in Nim manual:
https://nim-lang.org/docs/manual.html#generics-type-classes
But it is not clear how it should work:
#9443 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25826
This PR makes var type class parameters match any lvalues.
But it makes
expr is varis always true.