Repository navigation
Conversation
Moving an ungrouped tab to index -1 put it at the strip's end, where Firefox joined it into whichever group sat last. The sort now moves only groups, to explicit indexes: each group goes after the tabs of the groups placed before it, so no group is split. Ungrouped tabs are never passed to tabs.move. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Et6Fr6EXRmrdavvvh8wgC
|
@infixlabs is attempting to deploy a commit to the nitzanpap's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With "Keep groups sorted alphabetically" on,
sortGroupsends by callingtabs.move(id, { index: -1 })on every ungrouped tab. In Firefox, a tab moved to the end of the strip is absorbed into the group that sits last there. Result: single-site tabs that never reached the minimum join an unrelated group (for example, the alphabetically last one). Each close also re-moves every ungrouped tab, which reshuffles them.Change
moveUngroupedTabsToEndand its call. Ungrouped tabs are never passed totabs.move.pinnedCount+ cumulative sizes). A plainindex: pinnedCount + iwould land inside an earlier multi-tab group and split it in Firefox.Testing
vitest run: 965 passed on this branch (based on currentmaster).tsc --noEmitandbiome checkon the changed files: clean.Open question for maintainers: the sort now puts groups on the left instead of the right. Happy to flip the direction if that's a problem.
🤖 Generated with Claude Code