bugfix: Detached headers idempotence check - #1286
Open
Hussainity wants to merge 2 commits into
Open
Conversation
Hussainity
force-pushed
the
hm/probe-detached-header
branch
from
August 8, 2026 12:52
ba02cb2 to
93ec363
Compare
Author
|
@Lassulus requesting maintainer review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detached LUKS headers were not handled correctly by the
_createidempotence check inlib/types/luks.nix.The old logic still probed
config.device. For detached-header setups, that meant rerun could mis-detect an already-initialized LUKS device and fall back into luksFormat.Fix
Probe the actual LUKS header target instead of the payload device, and make the create guard depend only on
cryptsetup isLuksfor that target.Test
Add a detached-header regression test that exercises the direct-mode idempotence path.