feat(btrfs,luks): better default checksum collision resistance with xxhash - #1291
Open
nikelborm wants to merge 1 commit into
Open
feat(btrfs,luks): better default checksum collision resistance with xxhash#1291nikelborm wants to merge 1 commit into
nikelborm wants to merge 1 commit into
Conversation
…xhash Choose xxHash, which will catch errors with a higher probability. A single encrypted bit flip causes a 128-bit flip on the decrypted side. This makes the CRC32C property of being certain to catch 100% of errors in 1/2/3-bit flip use cases disappear and become probabilistic `1-2⁻³²`. And since we're already in a non-deterministic zone, it's better to choose the algorithm that has stronger collision resistance.
nikelborm
force-pushed
the
luks-btrfs-csum
branch
from
August 22, 2026 06:14
2506917 to
d7da8d6
Compare
Author
|
It probably would've been better to move this deeper into abstraction, like making disko detect btrfs-on-luks/btrfs-on-lvm-on-luks stacking and automatically add the necessary formatting option, but I'm not competent enough at the moment to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose xxHash, which will catch errors with a higher probability. A single encrypted bit flip causes a 128-bit flip on the decrypted side. This makes the CRC32C property of being certain to catch 100% of errors in 1/2/3-bit flip use cases disappear and become probabilistic
1-2⁻³². And since we're already in a non-deterministic zone, it's better to choose the algorithm that has stronger collision resistance.