Skip to content

test: add missing parse-level tests for ignore_comment edge cases #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shub-gour wants to merge 1 commit into
base: develop
Choose a base branch
from
+34 −0
Open

test: add missing parse-level tests for ignore_comment edge cases #5160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions tests/src/unit-regression2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,38 @@ TEST_CASE("regression tests 2")
CHECK(j.dump() == "{}");
}

//new test2
SECTION("issue #2330 - ignore_comment=true works before an array")
{
const std::string ss = "// this is a comment\n[1, 2, 3]";
const json j = json::parse(ss, nullptr, true, true);
CHECK(j.is_array());
CHECK(j.dump() == "[1,2,3]");
}

SECTION("issue #2330 - ignore_comment=true works with block comment before value")
{
const std::string ss = "/* block comment */\n{\"key\": 1}";
const json j = json::parse(ss, nullptr, true, true);
CHECK(j["key"] == 1);
}

SECTION("issue #2330 - ignore_comment=true works with comment after value")
{
const std::string ss = "{\"key\": 1}\n// trailing comment";
const json j = json::parse(ss, nullptr, true, true);
CHECK(j["key"] == 1);
}

SECTION("issue #2330 - ignore_comment=false throws on comment in input")
{
const std::string ss = "// comment\n{}";
CHECK_THROWS_AS(
json::parse(ss, nullptr, true, false),
json::parse_error
);
}

#ifdef JSON_HAS_CPP_20
#ifndef _LIBCPP_VERSION // see https://github.com/nlohmann/json/issues/4490
#if __has_include(<span>)
Expand Down Expand Up @@ -1213,6 +1245,8 @@ TEST_CASE("regression test #5074 - portable workaround for single-element brace
CHECK(j[0] == j_obj);
}



#if defined(JSON_BRACE_INIT_COPY_SEMANTICS) && (JSON_BRACE_INIT_COPY_SEMANTICS == 1)
TEST_CASE("regression test #5074 - single-element brace init with JSON_BRACE_INIT_COPY_SEMANTICS")
{
Expand Down