Skip to content

Stabilize Consumer API external event integration tests - #1522

Merged
tnotheis merged 1 commit into
mainfrom
agent/fix-consumer-api-external-event-flake
Aug 12, 2026
Merged

tnotheis merged 1 commit into
mainfrom
agent/fix-consumer-api-external-event-flake

Conversation

@tnotheis

@tnotheis tnotheis commented Aug 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • move the external-event sync polling helper into a reusable Client extension in the Consumer API integration test project
  • use the extension when starting external-event sync runs so tests wait for a created sync run instead of occasionally observing NoNewEvents
  • reuse the same polling behavior for message, peer feature flag, relationship template allocation, and file ownership external-event assertions

Root cause

The failing tests can race the asynchronous external event creation/unblocking flow. Occasionally a test starts or lists an external-event sync run before the expected event has been persisted, so the API returns no/newer events yet and the assertion fails even though the scenario is valid.

Validation

  • NUGET_PACKAGES="$PWD/.nuget/packages" NUGET_HTTP_CACHE_PATH="$PWD/.nuget/http-cache" DOTNET_CLI_HOME="$PWD/.dotnet" dotnet restore /p:ContinuousIntegrationBuild=true Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/ConsumerApi.Tests.Integration.csproj
  • NUGET_PACKAGES="$PWD/.nuget/packages" NUGET_HTTP_CACHE_PATH="$PWD/.nuget/http-cache" DOTNET_CLI_HOME="$PWD/.dotnet" dotnet build --no-restore /p:ContinuousIntegrationBuild=true Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/ConsumerApi.Tests.Integration.csproj

The full Docker-backed integration test matrix was not run locally.

@tnotheis tnotheis added the test This pull request contains only new or changed tests label Aug 12, 2026
@tnotheis tnotheis self-assigned this Aug 12, 2026
@tnotheis
tnotheis force-pushed the agent/fix-consumer-api-external-event-flake branch from c614faa to ed10581 Compare August 12, 2026 13:08
@tnotheis
tnotheis marked this pull request as ready for review August 12, 2026 13:08
@tnotheis
tnotheis requested a review from erbenjak August 12, 2026 13:08
@tnotheis tnotheis changed the title Stabilize consumer API external event integration tests Stabilize Consumer API external event integration tests Aug 12, 2026
@tnotheis
tnotheis merged commit da90ee1 into main Aug 12, 2026
23 checks passed
@tnotheis
tnotheis deleted the agent/fix-consumer-api-external-event-flake branch August 12, 2026 16:01
tnotheis added a commit that referenced this pull request Aug 13, 2026
Co-authored-by: Timo Notheisen <timo.notheisen@js-soft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test This pull request contains only new or changed tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant