Skip to content

OpenID4VC credential requests occasionally fail with an invalid proof - #1207

Merged
tnotheis merged 15 commits into
mainfrom
OpenID4VC-credential-requests-occasionally-fail-with-an-invalid-proof
Oct 22, 2026
Merged

tnotheis merged 15 commits into
mainfrom
OpenID4VC-credential-requests-occasionally-fail-with-an-invalid-proof

Conversation

@tnotheis

Copy link
Copy Markdown
Member

Readiness checklist

  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I added tests (if necessary).
  • I self-reviewed the PR.

Description

This should fix another one of our flaky tests. But not only that: there is a small chance of this happening in a real life scenario as well (about 1 out of 128 signatures, to be precise).
The fix adds a padding to the key parts in case they are shorter than 32 bytes

@tnotheis tnotheis self-assigned this Oct 12, 2026
@tnotheis tnotheis added the bug Something isn't working label Oct 12, 2026
@tnotheis
tnotheis enabled auto-merge (squash) October 12, 2026 15:04
mergify Bot added 14 commits October 13, 2026 08:47
@tnotheis
tnotheis requested a review from britsta October 22, 2026 07:53
@tnotheis
tnotheis merged commit 7c1156a into main Oct 22, 2026
15 checks passed
@tnotheis
tnotheis deleted the OpenID4VC-credential-requests-occasionally-fail-with-an-invalid-proof branch October 22, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants