feat: add crypto address string format rules - #257
Open
nieomylnieja wants to merge 15 commits into
Open
Conversation
github-actions
Bot
added
enhancement
|
Test coverage changes:
|
nieomylnieja
changed the title
# Conflicts: # internal/messagetemplates/templatekey_string.go
# Conflicts: # go.mod # go.sum # go.work.sum
# Conflicts: # cspell.json # go.mod # go.sum # internal/messagetemplates/templatekey_string.go # internal/messagetemplates/templates.go # pkg/rules/error_codes.go
Clarify that only golang.org/x modules are acceptable external dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pkg/ruleswas missing common cryptocurrency address string format validators that users otherwise had to reimplement in application code.Summary
Added BTC and ETH address string format rules with exported error codes, message templates, validation-plan descriptions, and focused tests.
Testing
Added rule tests covering accepted examples, invalid messages, and error-code assertions.
Release Notes
Added
rules.StringBTCAddress,rules.StringBTCBech32Address, andrules.StringETHAddress.