feat(cider): Umbriel loft and overlay OSD (1.10.0) - #680
Merged
ItsLemmy merged 2 commits intoSep 9, 2026
Conversation
Keep the bar chip while Cider is scratchpadded and restore it to the remembered workspace. Sit the now-playing toast on the overlay layer. Co-authored-by: Cursor <cursoragent@cursor.com>
Community validate-plugins.py does not allow [[panel]] layer, so keep plugin_api at 24 (argv runAsync) and let the host own overlay placement. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
dragged/ciderplugin.toml)What it does
Cider now-playing alerts (notification / OSD card) plus a sticky karaoke lyrics HUD.
This update (1.9.7 → 1.10.0):
External dependencies
python3,gtk3,gtk-layer-shell,python-gobject(declared inplugin.toml)umbriel(preferred, including loftmsgactions), elseniri, elsehyprctlparec(PulseAudio/PipeWire) for silence-aware plain-lyrics scroll — feature fails open without itTesting
Unit:
python -m unittest test_write_position.py test_lyrics_display.pyfromcider/scripts— 107 tests OKLint:
noctalia plugins lint cider— 0 errors, 0 warningsManifest:
python3 .github/workflows/scripts/validate-plugins.py— 163 plugins OKManual on Umbriel 0.1.0: loft hide, restore to remembered workspace (
DP-1:1tiled), left-click lyrics HUD, middle-click loft, chip stays while loftedRestore uses show-pad then
window-restore-from-scratchpad(hidden pad members ignorewindow-focus). If another client is stored in the same output pad, it can flash for a frame — compositor limit, not a group-toggle UX.Tested on Niri
Tested on Hyprland
Tested on Sway
Tested on another compositor: Umbriel
Noctalia version tested against: v5.0.1
Plugin API level: 24
Screenshots / Videos
HUD/OSD visuals are unchanged from the store thumbnail (
cider/thumbnail.webp, 960×540, from the official generator in #406 / #581). This PR adds compositor loft behavior.Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpis present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.