Repository navigation
Use modern versions of protobuf - #48
Conversation
nolanbconaway
left a comment
There was a problem hiding this comment.
Is this camel change something that google implemented in its own library?? how did that come about? I never truly understood how protobuf deserialization works, does the deserializer have a role in the field names?
I didn’t dig into where the change was coming from, I just saw the failures and inspected the new return from the Google transit library. I think it may have changed upstream due to just how many major versions they’ve gone through That said, I don’t think it’s a breaking change here |
|
This looks good. can you bump the version and ill take it from there? |
|
Great work! thanks @WardBrian ! |
|
2.1.0 should be ready to rip! |
Required a few tweaks to pydantic, since the keys are now camelCase rather than snake_case, but should be backwards compatible