Skip to content

Use modern versions of protobuf - #48

Merged
nolanbconaway merged 7 commits into
nolanbconaway:mainfrom
WardBrian:dep-updates
Sep 1, 2026
Merged

nolanbconaway merged 7 commits into
nolanbconaway:mainfrom
WardBrian:dep-updates

Conversation

@WardBrian

Copy link
Copy Markdown
Collaborator

Required a few tweaks to pydantic, since the keys are now camelCase rather than snake_case, but should be backwards compatible

nolanbconaway
nolanbconaway previously approved these changes Aug 31, 2026

@nolanbconaway nolanbconaway left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this camel change something that google implemented in its own library?? how did that come about? I never truly understood how protobuf deserialization works, does the deserializer have a role in the field names?

Comment thread src/underground/models.py Outdated
Comment thread setup.py
@WardBrian

Copy link
Copy Markdown
Collaborator Author

Is this camel change something that google implemented in its own library?? how did that come about? I never truly understood how protobuf deserialization works, does the deserializer have a role in the field names?

I didn’t dig into where the change was coming from, I just saw the failures and inspected the new return from the Google transit library. I think it may have changed upstream due to just how many major versions they’ve gone through

That said, I don’t think it’s a breaking change here

Comment thread src/underground/feed.py Outdated
nolanbconaway
nolanbconaway previously approved these changes Sep 1, 2026
@nolanbconaway

Copy link
Copy Markdown
Owner

This looks good. can you bump the version and ill take it from there?

@nolanbconaway

Copy link
Copy Markdown
Owner

Great work! thanks @WardBrian !

@nolanbconaway
nolanbconaway merged commit 860af77 into nolanbconaway:main Sep 1, 2026
5 checks passed
@nolanbconaway

Copy link
Copy Markdown
Owner

2.1.0 should be ready to rip!

@WardBrian
WardBrian deleted the dep-updates branch September 1, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants