Initial support for ReplicateV2 - #4168
Open
cthulhu-rider wants to merge 7 commits into
Open
Conversation
cthulhu-rider
changed the title
cthulhu-rider
force-pushed
the
replicate-v2
branch
3 times, most recently
from
September 9, 2026 15:39
70eadcd to
be39b31
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4168 +/- ##
==========================================
+ Coverage 31.03% 31.07% +0.03%
==========================================
Files 673 672 -1
Lines 40673 40726 +53
==========================================
+ Hits 12623 12654 +31
- Misses 28050 28072 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
replicate-v2
branch
3 times, most recently
from
September 9, 2026 15:55
9239cb9 to
e0aa31f
Compare
cthulhu-rider
marked this pull request as ready for review
September 9, 2026 16:58
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
September 9, 2026 16:58
| return grpcstatus.Error(grpccodes.Unimplemented, "no longer supported, use SearchV2") | ||
| } | ||
|
|
||
| func readFirstReplicateV2Request(stream protoobject.ObjectService_ReplicateV2Server) (*protoobject.ReplicateV2Request_Init, *protostatus.Status, error) { |
Member
There was a problem hiding this comment.
Can return (*protoobject.ReplicateV2Request_Init, error) and use apistatus.Error where appropriate.
Contributor
Author
There was a problem hiding this comment.
this would lead to a "there and back" in most cases. Don't think it's worth it
| // CompareAPIVersion performs three-way comparison of API server version against | ||
| // the given one. | ||
| func CompareAPIVersion(c MultiAddressClient, major uint32, minor uint32) int { | ||
| cv := c.APIVersion() |
Member
There was a problem hiding this comment.
Can have version.Version here as well.
|
|
||
| // CompareAPIVersion performs three-way comparison of API server version against | ||
| // the given one. | ||
| func CompareAPIVersion(c MultiAddressClient, major uint32, minor uint32) int { |
Member
There was a problem hiding this comment.
Can accept version.Version here and have a static var somewhere.
| chunkReqNum++ | ||
| } | ||
|
|
||
| chunkReqBufItems := make([]*[]byte, chunkReqNum) |
Member
There was a problem hiding this comment.
A lot of memory. Should use less.
Brings ReplicateV2 object API. Makes SN to serve API v2.27. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
As close to `Replicate` as possible. Various optimizations will be done in the future. Refs #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
This will be useful to implement switch b/w Replicate and ReplicateV2 using remote conn. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
These are the minimum necessary functional changes. They are not optimal due to duplicated requests when accessing multiple nodes and the request encoding of unary Replicate RPC even if it is not used. Optimizations will be made in the future. Refs #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
replicate-v2
branch
from
September 11, 2026 16:34
e0aa31f to
da20e97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.