feat(vi): add u, U visual mode commands#1087
Conversation
18d755a to
006825a
Compare
|
Thanks for this. One pre-existing limitation this surfaces: Also what through me off while testing is that single grapheme selections don't work, which is a repeating issue for Vi Mode. But all of these are not your problems to worry about. Fine with landing this now and thinking about the other stuff in follow-ups. @fdncred are you fine with this? |
|
Seems reasonable. It's up to you @kronberger-droid |
I noticed this as well since |
|
Could you still add a couple tests:
Otherwise good to land once tests are in. |
This PR adds the following commands to visual mode:
uto convert selection to lowercaseUto convert selection to uppercase~to switch case for each character in selectionThese match default vim mappings and would be especially useful when working with environment variables.
Added:
Command::LowercaseCommand::UppercaseEditCommand::LowercaseSelectionEditCommand::UppercaseSelectionEditCommand::SwitchcaseSelection