Skip to content

Add base64 chars sanitize function#3846

Open
matdodgson wants to merge 5 commits into
nvm-sh:masterfrom
matdodgson:add-base64-chars-sanitize-function
Open

Add base64 chars sanitize function#3846
matdodgson wants to merge 5 commits into
nvm-sh:masterfrom
matdodgson:add-base64-chars-sanitize-function

Conversation

@matdodgson
Copy link
Copy Markdown

In our use case we use our Nexus as a nodejs.org proxy with basic auth. The authorization header option should support the full base64 character set. I updated nvm_sanitize_auth_header to support this.

I also added a unit test.

I modified security_wget_injection as it was incompatible with supporting base64 encoding in the authorization header due to the "/tmp" assertion. I changed that test to check for dangerous shell metacharacters instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant