Skip to content

Add new partial pattern to help queries#905

Open
rays22 wants to merge 2 commits into
masterfrom
issue904
Open

Add new partial pattern to help queries#905
rays22 wants to merge 2 commits into
masterfrom
issue904

Conversation

@rays22

@rays22 rays22 commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

If applied, this commit will fix #904.

If applied, this commit will fix #904.
@rays22 rays22 requested review from matentzn and sbello March 2, 2023 16:59
@rays22 rays22 self-assigned this Mar 2, 2023
@sbello

sbello commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

@matentzn I don't think we wanted this to be a term creation pattern, correct? I thought what you wanted was to capture the standard for adding subclass axioms to existing terms to enrich the anatomy cross-references in the ontology. I don't think this should follow the standard set up for a UPheno pattern.
Anna and I discussed this with @rays22 at today's meeting

@matentzn

matentzn commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

I think its great to have this as a pattern - remember patterns are not only to "create new terms", but also to capture/document certain modelling decisions. I have some feedback on the PR, but it is definitely good to have these as a pattern.

@sbello

sbello commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

@matentzn I wasn't suggesting we not have the pattern but just questioning the need to have the term creating parts like name, definition, synonyms in the pattern. Having these here suggests that this pattern could be used to generate a new term and that is not the purpose in this case.

@matentzn

matentzn commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

You are 100% correct on that @sbello - sorry, misunderstood you. @rays22 we only need the subclass axiom template from the generative features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create a pattern for adding anatomy subclass axioms

3 participants