Conversation
This commit intends to restrict the scope of the abnormalLevelOfChemicalEntity pattern to apply to chemical qualities only in anatomical entities. To achieve this, the logical definition will be updated. If applied, this commit will fix #981.
sbello
left a comment
sbello
left a comment
There was a problem hiding this comment.
These changes make this identical to http://purl.obolibrary.org/obo/upheno/patterns/abnormalLevelOfChemicalEntityInLocation.yaml
No, not identical - there is no filler class in this pattern! Only the chemical entity and the fact that it is measured in some part of an organism (anatomical entity) |
|
Ah, okay. This needs to be made very clear, maybe add a note to the top. |
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Everything is correct about this PR but I am scared that if I merge it, I lose a lot of cross species mappings..
- This this pattern with a uPheno build
3 participants
This commit intends to restrict the scope of the abnormalLevelOfChemicalEntity pattern to apply to chemical qualities only in anatomical entities. To achieve this, the logical definition will be updated.
If applied, this commit will fix #981.