Skip to content

eio_windows: fix anonymous pipes on Windows - #929

Open
avsm wants to merge 2 commits into
ocaml-multicore:mainfrom
avsm:failing-win-pipe
Open

eio_windows: fix anonymous pipes on Windows#929
avsm wants to merge 2 commits into
ocaml-multicore:mainfrom
avsm:failing-win-pipe

Conversation

@avsm

@avsm avsm commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This is a testcase failing on my machine atm, so opening to check windows CI here as well (I'm struggling with Windows Redirection Guard nuking my ssh setup due to the use of symlinks in Flexlink!)

@avsm

avsm commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Confirming it fails in CI too

 [FAIL]        pipe             0   transfer.
  
    ... with 6 subsequent tests skipped.
  
  ┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ [FAIL]        pipe             0   transfer.                                                                         │
  └──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
  [exception] Eio.Io _
              Raised at Stdlib__Effect.Deep.discontinue.(fun) in file "effect.ml", line 63, characters 41-48
              Called from Eio_unix__Private.pipe in file "lib_eio/unix/private.ml", line 14, characters 13-37
              Called from Dune__exe__Test_pipe.test_transfer.(fun) in file "lib_eio_windows/test/test_pipe.ml", line 12, characters 13-29
              Called from Eio__core__Switch.run_internal in file "lib_eio/core/switch.ml", line 133, characters 8-12
              Re-raised at Eio__core__Switch.maybe_raise_exs in file "lib_eio/core/switch.ml", line 119, characters 21-56
              Called from Eio__core__Switch.run_internal in file "lib_eio/core/switch.ml", line 149, characters 4-21
              Called from Eio__core__Cancel.with_cc in file "lib_eio/core/cancel.ml", line 118, characters 8-12
              Re-raised at Eio__core__Cancel.with_cc in file "lib_eio/core/cancel.ml", line 120, characters 50-58
              Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 186, characters 17-23
              Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35

On Windows,an anonymous pipe cant be made non-blocking, so
this call always failed with an ENOTSOCK for me
@avsm
avsm marked this pull request as ready for review September 1, 2026 19:04
@talex5 talex5 added the windows label Sep 2, 2026
@avsm avsm changed the title eio_windows: test case for anonymous pipes eio_windows: fix anonymous pipes on Windows Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants