Add deterministic coverage for the EVM uuid partition-0 branch - #8637
Open
janezpodhostnik wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EVM environment selects a UUID register partition from
sha256(blockID)[0]. Partition 0 (probability 1/256 for a random block fixture) reuses the legacyuuidregister, which changes metering and register counts. This branch made exact assertions flaky (#8629, and theComputationUsedassertion fixed in #8634), and with random fixtures it is practically never exercised in CI.Changes
blockFixtureWithUUIDPartitionZero, a block fixture that deterministically selects partition 0, and a block-parameterized variant ofRunWithNewEnvironment.While investigating, confirmed the partition-dependent reads happen inside the dry-run's speculative (discarded) transaction: they are metered but do not appear in the returned execution snapshot, which is documented in the test.
Related: #8629, #8634
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.