Skip to content

[Testing] Fix flaky TestFailedTxWillNotChangeStateCommitment #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janezpodhostnik wants to merge 1 commit into from
+9 −4
Open

[Testing] Fix flaky TestFailedTxWillNotChangeStateCommitment #8639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions engine/execution/execution_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,12 @@ func TestFailedTxWillNotChangeStateCommitment(t *testing.T) {
assert.NoError(t, err)

// ensure block 1 has been executed
hub.DeliverAllEventually(t, func() bool {
// the receipt travels a multi-hop async pipeline (follower -> ingestion -> execution ->
// pusher -> stub network -> consensus mock), so use a generous liveness bound with a fast
// poll: it returns as soon as the receipt arrives and only slow, loaded runs pay the wait.
hub.DeliverAllEventuallyUntil(t, func() bool {
return receiptsReceived.Load() == 1
})
}, 60*time.Second, 100*time.Millisecond)

if exe1Node.StorehouseEnabled {
exe1Node.AssertHighestExecutedBlock(t, genesis.ToHeader())
Expand All @@ -507,9 +510,11 @@ func TestFailedTxWillNotChangeStateCommitment(t *testing.T) {
assert.NoError(t, err)

// ensure block 1, 2 and 3 have been executed
hub.DeliverAllEventually(t, func() bool {
// waiting for 2 more receipts doubles the pipeline hops compared to the wait above;
// under full-suite load this exceeded the 10s/500ms default bound of DeliverAllEventually.
hub.DeliverAllEventuallyUntil(t, func() bool {
return receiptsReceived.Load() == 3
})
}, 60*time.Second, 100*time.Millisecond)

// ensure state has been synced across both nodes
exe1Node.AssertBlockIsExecuted(t, block2.ToHeader())
Expand Down
Loading