Repository navigation
os update: a failed switch undo keeps the trial marker - #584
Merged
Merged
Conversation
Found by Greptile on the 0.16.0 release PR (#583). The marker is removed only after the booted slot is first again, so a new slot that may still boot next boots on trial.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile found this on the 0.16.0 release PR (#583, comment 4195158466). When an
os-switchjob stops aftermark-active otherand then cannot put the booted slot first again, it still removed the new slot's trial marker. The new slot could then boot next with no trial, so no safety net and no revert.Now the marker goes only after the booted slot is first again. If the old slot boots after all,
Bootalready removes a marker for a switch that never took effect (TestMarkerWithoutActivationIsNoRevert).TestFailedUndoKeepsTheTrialMarker. It fails without the fix.UPDATES.md# 1 and a progress entry,os-switch-undo-marker.md.Part of #486.