-
Notifications
You must be signed in to change notification settings - Fork 37
STAGING ONLY: Grants Monthly #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RabiaSajjad
wants to merge
42
commits into
master
Choose a base branch
from
grants-monthly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
705d005
new pd table for grants (monthly)
RabiaSajjad a80a726
add changelog for PR# 1525
RabiaSajjad 8c2c6e9
change template version and add excel style to grantsmonthly
RabiaSajjad 20e79d7
fix sorting for recombinant update pd record template
RabiaSajjad dc6dc09
add more choices to fields in grantsmonthly template
RabiaSajjad 4c1ec00
change title for grantsmonthly template and add example for Other field
RabiaSajjad 0bf4940
update notes for grantsmonthly template
RabiaSajjad 56908ed
add translations for grantsmonthly
RabiaSajjad b23f76b
add translation for other_dem_intended_beneficiary_description_fr fie…
RabiaSajjad e42e129
add field rating_risk to grantsmonthly template
RabiaSajjad 929f9ae
Merge branch 'master' into 'grants-monthly'
RabiaSajjad f997c28
format description for risk rating field in grants monthly template
RabiaSajjad 4330fa2
add grants-monthly to makefile
RabiaSajjad d96ac2e
Merge branch 'master' into 'grants-monthly'
RabiaSajjad 0f56810
change quarterly to monthly for grants-monthly table
RabiaSajjad e963416
remove plugins.py from grants-monthly
RabiaSajjad ad4c0d9
add grantsmonthly.csv to makefile
RabiaSajjad 86bd105
add published_resource_id for grantsmonthly.csv
RabiaSajjad 7f6a954
fix linting error in filter_grants_monthly
RabiaSajjad bd29ef3
add grantsmonthly to test ini file
RabiaSajjad 35a046e
fix linting error in grants filter
RabiaSajjad 7e82779
fix(pd): grants monthly example value;
JVickery-TBS a78d70c
fix(tests): make grants;
RabiaSajjad 83350f8
dep updates for grantsmonthly
RabiaSajjad e3b60c4
Merge branch 'master' into grants-monthly
JVickery-TBS a5b0711
fix(pd): grantsmonthly column type;
JVickery-TBS 6ff92cc
fix(syntax): lint;
JVickery-TBS bccb9b9
Merge branch 'master' into grants-monthly
JVickery-TBS 1b2f8dd
Grants monthly pilot, phase 2
RabiaSajjad d824b49
add translations for grantsmonthly phase 2
RabiaSajjad 35ce57a
add trigger string for grants montthly pilot phase 2
RabiaSajjad 97871f0
add more trigger string for grants montthly pilot phase 2
RabiaSajjad 91403ae
remove validation from grants monthly pilot phase 1 fields
RabiaSajjad 944e293
change required fields from grants monthly pilot phase 1
RabiaSajjad a4fe84c
fix Y/N options for grants monthly pilot phase 2 fields
RabiaSajjad aeba1b5
update option label for the recipient_type field
RabiaSajjad f293761
change the ref_number field description to show Q instead of M
RabiaSajjad 75c8f79
update description for field agreement_start_date
RabiaSajjad d292ff2
Merge branch 'master' into grants-monthly
JVickery-TBS 6f92e76
Merge branch 'master' into grants-monthly
JVickery-TBS 6286a35
feat(pd): grants pilot;
JVickery-TBS 93267da
update link in description for the naics identifier
RabiaSajjad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #!/usr/bin/env python3 | ||
| "filter for grantsmonthly.csv" | ||
|
|
||
| import csv | ||
| import sys | ||
|
|
||
| REMOVE_COLUMNS = [ | ||
| 'record_created', | ||
| 'record_modified', | ||
| 'user_modified', | ||
| ] | ||
|
|
||
| def main(): | ||
| reader = csv.DictReader(sys.stdin) | ||
| outnames = [f for f in reader.fieldnames if f not in REMOVE_COLUMNS] | ||
| writer = csv.DictWriter(sys.stdout, outnames) | ||
| writer.writeheader() | ||
| for row in reader: | ||
| try: | ||
| for rem in REMOVE_COLUMNS: | ||
| del row[rem] | ||
| writer.writerow(row) | ||
| except ValueError: | ||
| pass | ||
|
|
||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| New recombinant PD template for Grants (monthly). This template would be separate from | ||
| the existing Grants template and is targeted only for the Staging environment. Major difference | ||
| between the two templates are: | ||
| * Data collection is done quarterly for Grants vs monthly for Grants (monthly) | ||
| * The following fields exist in Grants but deprecated in Grants (monthly): | ||
| - 3.9 research_organization_name | ||
| - 3.14 federal_riding_name_en | ||
| - 3.15 federal_riding_name_fr | ||
| - 3.21 agreement_title_en | ||
| - 3.22 agreement_title_fr | ||
| - 3.25 foreign_currency_type | ||
| - 3.26 foreign_currency_value | ||
| - 3.29 coverage | ||
| - 3.32 naics_identifier | ||
| - 3.35 additional_information_en | ||
| - 3.36 additional_information_fr | ||
| * The following fields are new in the Grants (monthly) template: | ||
| - 3.26 dem_intended_beneficiary | ||
| - 3.27 other_dem_intended_beneficiary_description_en | ||
| - 3.28 other_dem_intended_beneficiary_description_fr | ||
| - 3.29 reason_amendment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.