Repository navigation
test: production-shaped tests for the three bugs found on delt.at - #63
Merged
Merged
Conversation
Each was invisible to the suite because the tests shared an assumption production broke: - Two issuers, one person: real RS256 tokens from both WorkOS issuers, a JWKS served over HTTP and the real OidcAdapter, through the /mcp handler. The owner of a calendar made through the site lists and approves its requests through MCP. The site's session and /mcp now verify through one shared canonicalVerifier, so the test runs the code production runs. - Two module graphs: the registry and meeting modules evaluated a second time (as server.ts and Next do) must share one instance. - Behind a proxy: the real sign-in, callback and sign-out handlers, given a request addressed to localhost:3000, must send people to the public site. siteOrigin reads PUBLIC_BASE_URL when called, so this never depends on which code loaded the module first. Each test was checked to fail against the code before its fix. CI's test job now builds @open-deltat/mcp too, as a clean checkout needs. Claude-Session: https://claude.ai/code/session_01DcoaetPzmP3YtMcN31C8Y3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that fail against the code before each of #60, #61 and #62, for the reason each slipped through:
OidcAdapter, end to end through/mcpwith the MCP SDK client. The site's session and/mcpnow share onecanonicalVerifier, so the test exercises what production runs.localhost:3000, must send people tohttps://delt.at.CI's test job now builds
@open-deltat/mcpbefore the tests, which a clean checkout needs.🤖 Generated with Claude Code
https://claude.ai/code/session_01DcoaetPzmP3YtMcN31C8Y3