Repository navigation
QFw: say which component wrote each log line - #50
Merged
Merged
Conversation
The logs panels show a line's body and hide its labels, and a job's story has two writers, so the eight lines under a trace gave no hint which two came from the client. Each query now ends in a line_format that prefixes the line with its writer, "[client]" or "[qpm fake-iqm-20q]", on the QFw Trace panel, the warnings panel of QFw Jobs and the hop from a span to its logs in Explore. The labels stay in a line's details. Signed-off-by: Doug Oucharek <dougso@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at a trace's eight log lines and could not tell which came from the client. The logs panel shows a line's body and hides its labels, and with openQSE/QFw#136 a job's story has two writers.
Each logs query now ends in a
line_formatthat prefixes the line with its writer, taken from the stream labels:[client]or[qpm fake-iqm-20q]. Applied to the QFw Trace panel, the "Recent warnings and errors" panel on QFw Jobs, and the Tempo datasource's span-to-logs query in Explore. The labels are still in a line's details. One paragraph intelemetry/README.mdsays so.Verified live: the provisioned QFw Trace dashboard reloaded with the new query and the panel reads
[client] submitted job ..., six[qpm fake-iqm-20q] ...lines,[client] job ... completed after 41.8 ms.