Skip to content

ci: make image publishing configurable #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rashadism wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −26
Open

ci: make image publishing configurable #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/configurable-image-publishing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
22 changes: 11 additions & 11 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ permissions:
pull-requests: write

env:
REGISTRY: ghcr.io
IMAGE_NAME: openchoreo/openchoreo-ui
OCI_REGISTRY_HOST: ${{ vars.OCI_REGISTRY_HOST || 'ghcr.io' }}
IMAGE_NAME: ${{ vars.IMAGE_NAME || 'openchoreo/openchoreo-ui' }}

jobs:
lint:
Expand Down Expand Up @@ -172,12 +172,12 @@ jobs:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Login to GitHub container registry
- name: Login to container registry
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: ${{ env.OCI_REGISTRY_HOST }}
username: ${{ env.OCI_REGISTRY_HOST == 'ghcr.io' && (secrets.OCI_REGISTRY_USERNAME || github.actor) || secrets.OCI_REGISTRY_USERNAME }}
password: ${{ env.OCI_REGISTRY_HOST == 'ghcr.io' && (secrets.OCI_REGISTRY_PASSWORD || github.token) || secrets.OCI_REGISTRY_PASSWORD }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # v3.10.0
Expand All @@ -187,18 +187,18 @@ jobs:
run: |
SHA=$(git rev-parse --short=8 HEAD)
echo "GIT_SHA_SHORT=$SHA" >> $GITHUB_OUTPUT
TAGS="${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:$SHA"
if [[ "${{ github.ref }}" == "refs/heads/main" ]]; then
TAGS="$TAGS,${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest-dev"
TAGS="$OCI_REGISTRY_HOST/$IMAGE_NAME:$SHA"
if [[ "$GITHUB_REF" == "refs/heads/main" ]]; then
TAGS="$TAGS,$OCI_REGISTRY_HOST/$IMAGE_NAME:latest-dev"
fi
echo "TAGS=$TAGS" >> $GITHUB_OUTPUT

- name: Check if image already exists
id: check-image
run: |
SHA=$(git rev-parse --short=8 HEAD)
if docker buildx imagetools inspect "${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA}" >/dev/null 2>&1; then
echo "Image ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA} already exists. Skipping build."
if docker buildx imagetools inspect "$OCI_REGISTRY_HOST/$IMAGE_NAME:${SHA}" >/dev/null 2>&1; then
echo "Image $OCI_REGISTRY_HOST/$IMAGE_NAME:${SHA} already exists. Skipping build."
echo "skip=true" >> $GITHUB_OUTPUT
else
echo "Image not found. Proceeding with build."
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ permissions:
contents: read

env:
REGISTRY: ghcr.io
IMAGE_NAME: openchoreo/openchoreo-ui
OCI_REGISTRY_HOST: ${{ vars.OCI_REGISTRY_HOST || 'ghcr.io' }}
IMAGE_NAME: ${{ vars.IMAGE_NAME || 'openchoreo/openchoreo-ui' }}

jobs:
release:
Expand Down Expand Up @@ -94,30 +94,30 @@ jobs:
yarn workspaces foreach --all --no-private --topological --verbose \
npm publish --tolerate-republish --access public --tag "${TAG}"

- name: Login to GitHub container registry
- name: Login to container registry
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: ${{ env.OCI_REGISTRY_HOST }}
username: ${{ env.OCI_REGISTRY_HOST == 'ghcr.io' && (secrets.OCI_REGISTRY_USERNAME || github.actor) || secrets.OCI_REGISTRY_USERNAME }}
password: ${{ env.OCI_REGISTRY_HOST == 'ghcr.io' && (secrets.OCI_REGISTRY_PASSWORD || github.token) || secrets.OCI_REGISTRY_PASSWORD }}

- name: Retag existing image with release version
run: |
IMAGE="${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}"
if ! docker buildx imagetools inspect "${IMAGE}:${{ env.GIT_SHA_SHORT }}" > /dev/null 2>&1; then
echo "::error::Image ${IMAGE}:${{ env.GIT_SHA_SHORT }} not found. Ensure the commit was pushed to a release branch before tagging."
IMAGE="$OCI_REGISTRY_HOST/$IMAGE_NAME"
if ! docker buildx imagetools inspect "${IMAGE}:${GIT_SHA_SHORT}" > /dev/null 2>&1; then
echo "::error::Image ${IMAGE}:${GIT_SHA_SHORT} not found. Ensure the commit was pushed to a release branch before tagging."
exit 1
fi
echo "Retagging ${IMAGE}:${{ env.GIT_SHA_SHORT }} -> ${IMAGE}:${{ env.RELEASE_TAG }}"
echo "Retagging ${IMAGE}:${GIT_SHA_SHORT} -> ${IMAGE}:${RELEASE_TAG}"
docker buildx imagetools create \
--tag "${IMAGE}:${{ env.RELEASE_TAG }}" \
"${IMAGE}:${{ env.GIT_SHA_SHORT }}"
--tag "${IMAGE}:${RELEASE_TAG}" \
"${IMAGE}:${GIT_SHA_SHORT}"

- name: Tag latest if highest stable version
if: env.LATEST == 'true' && env.IS_PRERELEASE == 'false'
run: |
IMAGE="${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}"
echo "Retagging ${IMAGE}:${{ env.RELEASE_TAG }} -> ${IMAGE}:latest"
IMAGE="$OCI_REGISTRY_HOST/$IMAGE_NAME"
echo "Retagging ${IMAGE}:${RELEASE_TAG} -> ${IMAGE}:latest"
docker buildx imagetools create \
--tag "${IMAGE}:latest" \
"${IMAGE}:${{ env.RELEASE_TAG }}"
"${IMAGE}:${RELEASE_TAG}"
Loading