Repository navigation
fix: preserve scoped OCM during Gateway resource lookup - #274
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: preserve scoped OCM during Gateway resource lookup This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
A Gateway can start correctly while Kova reports incomplete startup coverage because resource discovery cannot find its PID. The PID lookup launches a login shell that can replace the scoped PATH and select a different OCM executable from the one that started the Gateway.
User Impact
Gateway resource discovery respects the configured OCM environment and observes the same Gateway used by scenario execution. Cross-user OCM transport keeps its existing behavior.
Why This Change Was Made
Use the existing OCM argv invocation helper for local and transported discovery. This removes the extra login-shell layer rather than trying to restore PATH after shell startup. The timeout fixture now supplies a hanging OCM executable, preserving the proof that stalled probes are killed and reaped.
Evidence
The new PATH-replacement regression fails on main and passes with the fix. All 17 startup-resource tests pass, including complete cold-start and warm-restart observation. The full documented Linux gate passed across the completed runs: command/accounting tests, isolation checks, self-check, snapshots, web payload, release contracts, and release archive packaging.
Codex autoreview found no actionable P0–P2 findings. The first CI run identified the shell-dependent timeout fixture; it was corrected and the failed test passed. The updated exact-head CI is the final cross-platform gate.