Repository navigation
fix: stop Gateway scenarios when readiness fails - #276
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 21, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A scenario could send a cold turn after its Gateway failed the readiness check. The resulting socket error hid the earlier startup failure.
User Impact
Kova ends a scenario at a failed product readiness checkpoint and keeps the probe result available for diagnosis.
Why This Change Was Made
The service command can succeed before the Gateway accepts traffic. Use the collected
/readyzresult to decide whether to proceed. Harness checkpoints still collect their upgrade evidence, and ordinary teardown runs after the failed product checkpoint.Evidence
/healthwith 200 and/readyzwith 503. The runner still executed the dependent turn. AWS Crabbox reprobd5c3b95d87. AWS Crabbox test output