Repository navigation
test(cli): verify clone deadlines at the installer boundary - #110
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
…gnals * origin/main: ci: report package consumer phase timings (#106) fix(ci): honor the offline consumer cache and check Node 26 (#104) refactor(runtime): share Hermes rewrites, task responses, and install setup (#103) perf(ci): skip package reinstall for source-test-only changes (#101) test(mcp): exercise commands and tasks from the installed tarball (#100) # Conflicts: # src/cli.test.ts
vincentkoc
added a commit
that referenced
this pull request
Nov 20, 2026
* origin/main: perf(hermes): reuse skill discovery during registry rebuilds (#107) refactor(hermes): dispatch single-argument event callbacks directly (#113) test(cli): verify clone deadlines at the installer boundary (#110) refactor(hooks): keep session start state in one record (#112) refactor(cli): share host command registration (#109) refactor(hooks): count unique files once during discovery (#108) # Conflicts: # CHANGELOG.md # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows CLI suite spent two 10-second intervals waiting for stalled clones, duplicating the installer's real transport tests. Check CLI flag and environment forwarding at the installer boundary. The existing CLI test still installs a real repository to verify option precedence, while both real timeout cleanup cases in the installer continue checking socket closure, staging cleanup and preservation of an existing plugin.
Verification
All 36 CLI and Git installer tests passed locally. The platform matrix continues to exercise the real process termination behavior on Windows, macOS and Linux.
git diff --checkpassed.