Skip to content

fix(import): accept in-root paths beginning with two dots - #34

Merged
steipete merged 1 commit into
mainfrom
maintenance/sweep-3
Sep 22, 2026
Merged

steipete merged 1 commit into
mainfrom
maintenance/sweep-3

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

Plugin discovery rejected valid in-root directories such as ..skills because the containment checks treated every name beginning with two dots as parent traversal. Check for the complete parent segment instead, in both the lexical and realpath checks.

Compatibility

Claude Code and Codex skill discovery now accepts these ordinary directory names. Parent traversal, cross-root paths, and escaping skill-root symlinks remain rejected. No command, hook-execution, manifest, or trust-permission contract changes.

Verification

  • Regression before fix: both source-app cases failed with Plugin path escapes its root: ..skills; actual traversal cases passed.
  • Focused regression after fix: five tests passed, including traversal and symlink-escape rejection.
  • Full remote gate passed on Linux / Node 24.18.1: npm ci --include=dev && npm run check && npm run pack:check (84 tests, package contents verified).
  • Codex autoreview: scoped-clean through P2.
  • README compatibility table, compatibility reference, and Unreleased changelog updated.

@steipete
steipete requested a review from RomneyDa September 22, 2026 08:45
@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper

clawsweeper Bot commented Sep 22, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(import): accept in-root paths beginning with two dots This is item 1/1 in the current shard. Shard 0/1.

This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit 98db8c1 into main Sep 22, 2026
9 checks passed
@vincentkoc
vincentkoc deleted the maintenance/sweep-3 branch September 25, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant