Repository navigation
fix(import): accept in-root paths beginning with two dots - #34
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(import): accept in-root paths beginning with two dots This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin discovery rejected valid in-root directories such as
..skillsbecause the containment checks treated every name beginning with two dots as parent traversal. Check for the complete parent segment instead, in both the lexical and realpath checks.Compatibility
Claude Code and Codex skill discovery now accepts these ordinary directory names. Parent traversal, cross-root paths, and escaping skill-root symlinks remain rejected. No command, hook-execution, manifest, or trust-permission contract changes.
Verification
Plugin path escapes its root: ..skills; actual traversal cases passed.npm ci --include=dev && npm run check && npm run pack:check(84 tests, package contents verified).