Skip to content

fix(release): qualify and protect babelfish 0.1.1 publication - #47

Merged
vincentkoc merged 4 commits into
mainfrom
release/0.1.1-prep
Oct 1, 2026
Merged

vincentkoc merged 4 commits into
mainfrom
release/0.1.1-prep

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Prepare Babelfish 0.1.1 after fix(hooks): continue tool calls when the Hermes bridge cannot start #46 on verified main dee86b098869f8b3db890ae8e638d5ba23c97ef2.
  • Date the changelog 2026-10-01 without dropping contributor entries or credits; align both MCP runtime identities and the issue-template example; ship the README-linked compatibility guide.
  • Replace dry-run packaging and checkout imports with actual tarball validation and a fresh production-only builtin consumer: installed CLI help, Hermes/Claude Code/Codex lifecycle, generated contracts, MCP echo, registered native runtime/session, strict NodeNext declarations with a separate pinned compiler/types, and real late-regeneration force-install rollback with exact byte restoration and no staging residue.
  • Add a release-only protected signed-tag workflow: one immutable reusable artifact; isolated trusted-OIDC publisher; separate unprivileged registry signature/Sigstore provenance/fresh-consumer verifier; separate GitHub promotion. All actions are pinned and runners are GitHub-hosted.
  • Preserve package/lock version and all dependencies. The larger change is release gating and executable proof, not new plugin functionality. Docker only prequalifies the separate consumer toolchain/cache before offline low-memory checks.

Compatibility

  • Source apps: Hermes Agent, Claude Code, Codex; existing compatibility semantics retained.
  • Affected surfaces: MCP version identity, public package contents, package proof, release workflow.
  • Trust boundaries: publisher has only contents:read and id-token:write, uses stable-release, and has no checkout/install/cache/lifecycle. Exact E404 admits one publish invocation; existing/uncertain writes reconcile retained bytes and never blindly republish. Mandatory verifier checks cryptographic signatures/provenance and exact subject/source/workflow/tag/repository/run/publishing-attempt identities before promotion.
  • Release execution follows merge and a fresh protection/npm preflight. Missing npm trusted publishing must surface as a protected workflow blocker; no token fallback or authentication changes.

Verification

  • Focused release guard tests: 31 passed; focused MCP/client identity checks and the full suite pass.
  • npm run check: 250 passed across 14 files, build passed.
  • Real package/fresh production CLI/runtime/MCP/strict declarations/rollback proof passed; 25 files, 72073 compressed bytes, SHA256 a2349d9521f7af1ec4246e2078f30e758ec7ff818cd279f13ff15b247954f050.
  • actionlint, embedded publisher Python syntax, Node script syntax, and diff whitespace checks passed.
  • README package compatibility link and dated changelog updated; private data/generated outputs/dependency changes excluded.
  • Local Docker low-memory tiers 1 GiB, 512 MiB, and 256 MiB: exit 0, no OOM. The full tier also proves the real fresh production package offline after online cache qualification.
  • Independent static review: full diff requalified after scoped retry/cache and CodeQL encoding repairs; final ClawSweeper helper-boundary repairs under exact-head review.
  • Exact-head hosted CI/low-memory/CodeQL and durable ClawSweeper verdict are required before leaving draft and squash merging.

Current release-prep head: 220c5834bab649bb1dee0a4dfb5a578c4cf59673. Scoped review repairs cover failed-job retry admission, offline registry packument qualification, complete npm PURL encoding, digit-bearing artifact outputs, and canonical repository metadata URLs. Focused regressions cover both deterministic ClawSweeper findings. No dependencies or public runtime contracts changed.

This is the release preparation PR only. Contributor PRs are settled and are not reopened or rerun.

@vincentkoc vincentkoc self-assigned this Oct 1, 2026
@clawsweeper

clawsweeper Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

Comment thread scripts/release-common.mjs Fixed
@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 1, 2026
@clawsweeper

clawsweeper Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed October 1, 2026, 7:17 AM ET / 11:17 UTC (Revision 2).

ClawSweeper review

What this changes

The branch qualifies Babelfish 0.1.1 packages in an isolated consumer, aligns MCP version identities, and adds signed-tag publication with independent registry verification.

Merge readiness

✅ Ready for maintainer review

The prior blockers are repaired, and no remaining actionable defect was found. The release preparation remains necessary because current main lacks the introduced publication workflow and installed-package validation.

Priority: P2
Reviewed head: 220c5834bab649bb1dee0a4dfb5a578c4cf59673

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) The repaired branch has focused regression coverage and coherent release boundaries, with no remaining actionable finding.
Proof confidence 🌊 off-meta tidepool Not applicable: The MEMBER-authored PR is exempt from ordinary contributor proof; its captured body reports installed-package CLI, MCP, runtime/session, declarations, and rollback results. The new publication path is intentionally exercised after merge. No stored-data contract changes or unresolved authority violation were identified.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: The MEMBER-authored PR is exempt from ordinary contributor proof; its captured body reports installed-package CLI, MCP, runtime/session, declarations, and rollback results. The new publication path is intentionally exercised after merge. No stored-data contract changes or unresolved authority violation were identified.
Evidence reviewed 10 items Policy and source identity: Read the complete root AGENTS.md; no nested policy or maintainer-notes directory was found. The checkout is the pinned original PR head, and origin identifies the target repository.
Prior findings resolved: The exact earlier-head comparison confirms that output names now permit digits after the initial character and empty repository endpoints omit the trailing slash. Added regressions cover the complete admission output set, URL construction, and newline rejection; both previous findings are resolved.
Publication privilege boundary: The introduced workflow separates source/build execution, an environment-protected OIDC publisher without checkout or dependency installation, unprivileged registry verification, and GitHub promotion. Publication admits exact E404 once and reconciles retained bytes after uncertain writes.
Findings None None.
Security None None.

How this fits together

Babelfish translates Hermes, Claude Code, and Codex plugins for OpenClaw. Its release tooling turns built package contents into a tested npm archive, then verifies publication before promoting the GitHub release.

flowchart TD
  A[Signed protected tag] --> B[Validate source]
  B --> C[Build and test package]
  C --> D[Retain immutable archive]
  D --> E[Protected npm publisher]
  E --> F[Registry and consumer verification]
  F --> G[GitHub release promotion]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Production and test growth release/package tooling +550 lines; runtime +0 net lines; tests +156 lines The added tooling has a stated purpose: validate installed package bytes and gate publication independently.
Release privilege separation 4 jobs; 1 OIDC publisher; 1 GitHub write job Package execution, npm publication, verification, and release promotion have distinct permission boundaries.

Technical review

Best possible solution:

Retain the isolated publication and verification design, then follow the documented protected-tag and npm preflight procedure for the first release.

Do we have a high-confidence way to reproduce the issue?

Not applicable to the release preparation as a whole; source inspection and the exact GitHub comparison establish that both previously reported helper failures are repaired.

Is this the best way to solve the issue?

Yes. Validating retained package bytes in a fresh consumer and separating publication from verification is a focused improvement over main's dry-run and checkout-import checks.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against dee86b098869.

Labels

Label changes:

  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The MEMBER-authored PR is exempt from ordinary contributor proof; its captured body reports installed-package CLI, MCP, runtime/session, declarations, and rollback results. The new publication path is intentionally exercised after merge. No stored-data contract changes or unresolved authority violation were identified.
  • remove rating: 🦐 gold shrimp: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.
  • remove status: ⏳ waiting on author: Current PR status label is status: 👀 ready for maintainer look.
  • remove merge-risk: 🚨 automation: Current PR review selected no merge-risk labels.

Label justifications:

  • P2: This is bounded release qualification and publication hardening without an observed urgent runtime regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The MEMBER-authored PR is exempt from ordinary contributor proof; its captured body reports installed-package CLI, MCP, runtime/session, declarations, and rollback results. The new publication path is intentionally exercised after merge. No stored-data contract changes or unresolved authority violation were identified.

Evidence

What I checked:

  • Policy and source identity: Read the complete root AGENTS.md; no nested policy or maintainer-notes directory was found. The checkout is the pinned original PR head, and origin identifies the target repository. (AGENTS.md:1, 220c5834bab6)
  • Prior findings resolved: The exact earlier-head comparison confirms that output names now permit digits after the initial character and empty repository endpoints omit the trailing slash. Added regressions cover the complete admission output set, URL construction, and newline rejection; both previous findings are resolved. (scripts/release-common.mjs:23, 220c5834bab6)
  • Publication privilege boundary: The introduced workflow separates source/build execution, an environment-protected OIDC publisher without checkout or dependency installation, unprivileged registry verification, and GitHub promotion. Publication admits exact E404 once and reconciles retained bytes after uncertain writes. (.github/workflows/release.yml:90, 220c5834bab6)
  • Affirmative npm dependency contract: The verifier consumes npm audit's attestation bundles and checks the npm-generated provenance statement, establishing a direct dependency on npm 11.19.1's output contract. (scripts/verify-release.mjs:55, 220c5834bab6)
  • Verified audit output contract: npm 11.19.1 emits verified entries with registry and attestationBundles when --json --include-attestations is enabled, matching the consumer and release verifier. The version tag resolves to the recorded dependency commit. (lib/utils/verify-signatures.js, 3acf9a784798)
  • Verified provenance producer: The pinned npm producer emits the statement type, workflow identity, source dependency, GitHub repository identities, hosted builder, and attempt-specific invocation expected by the branch's provenance validator. (workspaces/libnpmpublish/lib/provenance.js, 3acf9a784798)

Likely related people:

  • vincentkoc: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
  • steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (1 earlier review cycle)
  • reviewed 2026-10-01T11:08:22.604Z sha 4ba4e9b :: blocked before merge. :: [P1] Allow digits in the hash output names | [P1] Omit the trailing slash for repository metadata requests

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. labels Oct 1, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review October 1, 2026 11:20
@vincentkoc
vincentkoc merged commit f33c4d0 into main Oct 1, 2026
12 of 13 checks passed
@vincentkoc
vincentkoc deleted the release/0.1.1-prep branch October 1, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants