Skip to content

docs: correct FIFO input and supported TTS engines - #15

Merged
steipete merged 2 commits into
mainfrom
docs/fifo-and-tts-help
Oct 7, 2026
Merged

steipete merged 2 commits into
mainfrom
docs/fifo-and-tts-help

Conversation

@steipete

Copy link
Copy Markdown
Contributor

The FIFO example split its redirection onto a separate line and omitted a newline, so copying it did not send the documented transcript. Keep the quoted text, newline, and FIFO redirection in one command.

CLI help and the README also advertised piper and elevenlabs, but the engine factory only implements system and none. List the supported choices consistently without changing engine behavior.

Validation: executed the README command against a real named pipe and verified exactly hey computer turn on the lights plus one newline. Independent Codex autoreview found no actionable P0–P2 issues.

Linux amd64 / Go 1.27.0 remote validation passed: go test ./..., go build ./cmd/clawgo, the built binary’s run -h output lists only system, none, and the README command delivered exactly one complete transcript through a real named pipe.

@steipete
steipete requested a review from vincentkoc September 23, 2026 07:23
@clawsweeper

clawsweeper Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 23, 2026
@clawsweeper

clawsweeper Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed October 6, 2026, 4:37 AM ET / 08:37 UTC (Revision 6).

ClawSweeper review

What this changes

Corrects the README’s named-pipe transcript command and makes README and CLI help list only the supported speech engines.

Merge readiness

✅ Ready for maintainer review

This PR remains useful: current main still contains both inaccuracies, and the focused corrections have adequate behavior evidence with no actionable findings.

Priority: P3
Reviewed head: 082ae1deafb7511bc4e5c66dbaa90c61a634015d

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, correct patch with relevant real-run evidence and no remaining review blockers.
Proof confidence 🐚 platinum hermit (4/6) Sufficient (live_output): The captured body reports after-fix execution of the exact README command through a real named pipe and the built CLI’s changed run-help output on Linux. These observations cover the changed behavior; no stored-data contract changes.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Verified Sufficient (live_output): The captured body reports after-fix execution of the exact README command through a real named pipe and the built CLI’s changed run-help output on Linux. These observations cover the changed behavior; no stored-data contract changes.
Evidence reviewed 6 items Verified introduced scope: The pinned base-to-head diff changes only the FIFO example, two speech-engine help strings, the README engine list, and an Unreleased changelog entry.
Current main still needs the correction: Main advertises piper and elevenlabs and splits the transcript printf from its FIFO redirection; the branch fixes both.
Authoritative engine contract: The engine factory accepts system and none, with an empty value also disabling speech; other engine names return an unsupported-engine error. This factory is unchanged by the PR.
Findings None None.
Security None None.

How this fits together

Clawgo reads line-delimited transcripts from stdin or a named pipe and forwards them to the gateway. Chat replies can be spoken through its local system speech engine.

flowchart LR
  A[Transcript command] --> B[Named pipe]
  B --> C[Clawgo line reader]
  C --> D[Gateway]
  D --> E[Chat replies]
  E --> F[Speech engine choice]
  F --> G[System speech or silence]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

None.

Technical review

Best possible solution:

Keep the transcript example executable as copied and align both CLI help paths with the implemented speech-engine choices.

Do we have a high-confidence way to reproduce the issue?

Yes, source establishes both inaccuracies: main separates the FIFO redirection from printf and advertises engines rejected by its factory. No reviewer-side runtime reproduction was performed.

Is this the best way to solve the issue?

Yes, the patch narrowly repairs the example and both help paths without changing supported engines, defaults, or user settings.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 9d0188637d96.

Labels

Label changes:

No label changes.

Label justifications:

  • P3: This focused documentation and help correction preserves runtime behavior and configuration.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The captured body reports after-fix execution of the exact README command through a real named pipe and the built CLI’s changed run-help output on Linux. These observations cover the changed behavior; no stored-data contract changes.
  • proof: sufficient: Contributor real behavior proof is sufficient. The captured body reports after-fix execution of the exact README command through a real named pipe and the built CLI’s changed run-help output on Linux. These observations cover the changed behavior; no stored-data contract changes.

Evidence

What I checked:

  • Verified introduced scope: The pinned base-to-head diff changes only the FIFO example, two speech-engine help strings, the README engine list, and an Unreleased changelog entry. (082ae1deafb7)
  • Current main still needs the correction: Main advertises piper and elevenlabs and splits the transcript printf from its FIFO redirection; the branch fixes both. (README.md:29, 9d0188637d96)
  • Authoritative engine contract: The engine factory accepts system and none, with an empty value also disabling speech; other engine names return an unsupported-engine error. This factory is unchanged by the PR. (cmd/clawgo/main.go:1041, 9d0188637d96)
  • After-fix behavior evidence: The captured PR body reports Linux amd64/Go 1.27.0 validation: the built binary's run help lists system and none, and the exact README command delivered the complete transcript plus one newline through a real named pipe. Reported tests and build are supplemental; no reviewer execution was performed. (082ae1deafb7)
  • Related work and release check: GitHub lists this PR as open and unmerged. The repository-wide PR list contains no merged replacement for these corrections, and the releases endpoint returns zero releases.
  • Area routing history: Local path history and GitHub merged-PR records connect steipete to recent chat-subscription maintenance and SebTardif to system speech argument handling. Older blob availability prevented full blame and parent-patch inspection, so these are routing candidates without introduction attribution. (cmd/clawgo/main.go, 9d0188637d96)

Likely related people:

  • steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
  • SebTardif: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (5 earlier review cycles)
  • reviewed 2026-09-23T07:26:53.793Z sha 082ae1d :: needs maintainer review before merge. :: none
  • reviewed 2026-09-26T12:53:05.413Z sha 082ae1d :: needs maintainer review before merge. :: none
  • reviewed 2026-10-02T10:46:49.698Z sha 082ae1d :: needs maintainer review before merge. :: none
  • reviewed 2026-10-03T22:51:46.012Z sha 082ae1d :: needs maintainer review before merge. :: none
  • reviewed 2026-10-05T14:35:36.696Z sha 082ae1d :: needs maintainer review before merge. :: none

@clawsweeper

clawsweeper Bot commented Oct 7, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: docs: correct FIFO input and supported TTS engines This is item 1/1 in the current shard. Shard 0/1.

This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit 0323de0 into main Oct 7, 2026
5 checks passed
@steipete
steipete deleted the docs/fifo-and-tts-help branch October 7, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant