Repository navigation
docs: correct FIFO input and supported TTS engines - #15
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 6, 2026, 4:37 AM ET / 08:37 UTC (Revision 6). ClawSweeper reviewWhat this changesCorrects the README’s named-pipe transcript command and makes README and CLI help list only the supported speech engines. Merge readiness✅ Ready for maintainer review This PR remains useful: current main still contains both inaccuracies, and the focused corrections have adequate behavior evidence with no actionable findings. Priority: P3 Review scores
Verification
How this fits togetherClawgo reads line-delimited transcripts from stdin or a named pipe and forwards them to the gateway. Chat replies can be spoken through its local system speech engine. flowchart LR
A[Transcript command] --> B[Named pipe]
B --> C[Clawgo line reader]
C --> D[Gateway]
D --> E[Chat replies]
E --> F[Speech engine choice]
F --> G[System speech or silence]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Keep the transcript example executable as copied and align both CLI help paths with the implemented speech-engine choices. Do we have a high-confidence way to reproduce the issue? Yes, source establishes both inaccuracies: main separates the FIFO redirection from printf and advertises engines rejected by its factory. No reviewer-side runtime reproduction was performed. Is this the best way to solve the issue? Yes, the patch narrowly repairs the example and both help paths without changing supported engines, defaults, or user settings. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 9d0188637d96. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: docs: correct FIFO input and supported TTS engines This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
The FIFO example split its redirection onto a separate line and omitted a newline, so copying it did not send the documented transcript. Keep the quoted text, newline, and FIFO redirection in one command.
CLI help and the README also advertised
piperandelevenlabs, but the engine factory only implementssystemandnone. List the supported choices consistently without changing engine behavior.Validation: executed the README command against a real named pipe and verified exactly
hey computer turn on the lightsplus one newline. Independent Codex autoreview found no actionable P0–P2 issues.Linux amd64 / Go 1.27.0 remote validation passed:
go test ./...,go build ./cmd/clawgo, the built binary’srun -houtput lists onlysystem, none, and the README command delivered exactly one complete transcript through a real named pipe.