Skip to content

improve(web): workspace settings explain deletion and an empty ownership transfer - #327

Merged
steipete merged 4 commits into
openclaw:mainfrom
KrasimirKralev:improve/workspace-danger-zone-hints
Nov 14, 2026
Merged

steipete merged 4 commits into
openclaw:mainfrom
KrasimirKralev:improve/workspace-danger-zone-hints

Conversation

@KrasimirKralev

@KrasimirKralev KrasimirKralev commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Fixes: a workspace owner opening Settings → Overview cannot tell how to delete the workspace or why ownership cannot be transferred.

  • The delete field shows the workspace name as grey placeholder text, so it looks already filled in, while the button stays disabled. Nothing says the name must be typed, and the field has no accessible name.
  • When no member is eligible, the transfer menu is blank and disabled, with no explanation.

User Impact

User impact: owners see "Type the workspace name to confirm." next to the delete field, and screen readers announce the field's purpose. A workspace with no eligible member shows "No eligible members" and "Add a human member who is not a guest first." instead of a blank menu.

No behavior changes: delete still needs the exact name, transfer still goes to the same members, and the API is untouched. While the member list is loading or has failed, the empty message stays hidden, so a failed load does not claim there are no members.

Why This Change Was Made

The confirmation rule lived only in canDelete, and the page had no state for "the member list loaded and nobody qualifies". This adds the hint, an aria-label, and a derived noTransferMembers state. docs/features/workspaces.md gets one line, and apps/api/internal/webassets/dist is rebuilt because CI requires it to be current.

Evidence

Real server (clickclack serve --dev-bootstrap=true, Linux) with a newly created workspace that has only its owner, in headless Chrome at 1280×800. Same steps on both builds.

Before After
before after

New Playwright spec tests/e2e/workspace-danger-zone.spec.ts, run against those same builds:

base:   2 failed, 1 passed
branch: 3 passed

The two failures on base are the delete hint and the empty transfer state. The delete field's accessible name is "Name to confirm deletion", so the existing getByLabel("Workspace name") selectors in tests/e2e/routing.spec.ts still match only the profile field: playwright test tests/e2e/workspace-danger-zone.spec.ts tests/e2e/routing.spec.ts → 18 passed on the branch. The third test passes on both: it guards the failed-load and has-member states, where the empty message must stay hidden. It serves the member list through a mocked route, because the HTTP API cannot add a human member.

Not tested: a real transfer or deletion (the spec only checks that the delete button enables), the desktop app, and a real screen reader. The accessible name is checked through Playwright's role query.

@KrasimirKralev
KrasimirKralev requested a review from a team as a code owner November 9, 2026 08:22
@clawsweeper

clawsweeper Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: sufficient Contributor real behavior proof is sufficient. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. labels Nov 9, 2026
@clawsweeper

clawsweeper Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

The workspace overview explains deletion confirmation, labels its input, and explains an empty ownership-transfer selector.

Example: Acme Support has only its owner.

  • Before: The ownership selector is blank, and the deletion field does not explain that Acme Support must be typed.
  • After: The selector says No eligible members, and the page explains member eligibility and deletion confirmation.

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) A small, useful repair with direct browser proof, focused regression coverage, and no actionable findings.
Proof confidence 🦞 diamond lobster (5/6) ✨ media proof bonus Sufficient (screenshot): Inspected before and after screenshots show the changed overview page against the reported real Linux server in Chrome; supplied Playwright results report base failures and branch passes for both explanations, plus accessible-name and alternate-state coverage.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Workspace owners encounter an unexplained disabled ownership selector and a deletion confirmation field without an accessible name or typing instruction.
Reason: The change resolves concrete accessibility and comprehension problems while preserving existing eligibility, confirmation, and authorization behavior.

Merge readiness

✅ Ready for maintainer review

This PR provides a useful accessibility and usability fix absent from current main; no actionable correctness or security defect was found.

Priority: P3
Reviewed head: 6bedaceda8e7481fe60dbb74df235ff8269edbe7

Before merge

None.

Findings

None.

Agent review details

How this fits together

The workspace overview receives workspace identity and the member directory, renders existing administration controls, and submits transfer or deletion requests through unchanged APIs.

flowchart TD
  A[Workspace owner] --> B[Overview settings]
  C[Workspace identity] --> B
  D[Member directory API] --> E[Existing eligibility filter]
  E --> B
  B --> F[Confirmation and empty state hints]
  B --> G[Workspace administration API]
Loading

Technical review

Best possible solution:

Keep the explanations and accessible label in the existing overview page while preserving its administration rules.

Do we have a high-confidence way to reproduce the issue?

Current-main source exposes the unnamed deletion input and unexplained empty selector, corroborated by the contributor's before screenshot; no target code was run during this review.

Is this the best way to solve the issue?

The patch uses the existing successful-load marker and eligibility list, providing a small complete fix without introducing a second owner or changing APIs.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 03e85d6c704a.

Provenance checked

  • Workspace deletion confirmation and ownership selection keeps the original intent (Wire workspace admin controls #54: Provide owner-only permanent deletion and ownership transfer to eligible human members across the complete member directory.)
  • Embedded application assets keeps the original intent (f7e3ad1: Regenerate the embedded web application after dependency updates; this PR maintains matching source and generated application references.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit bbb474d adds apps/web/src/routes/app/[workspaceID]/(settings)/settings/overview/+page.svelte:141 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: bbb474d0623a; files: apps/web/src/routes/app/[workspaceID]/(settings)/settings/overview/+page.svelte)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • remove rating: 🐚 platinum hermit: Current PR rating is rating: 🦞 diamond lobster, so this older rating label is no longer current.

Label justifications:

  • P3: A focused accessibility and discoverability improvement to existing workspace settings.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • proof: sufficient: Contributor real behavior proof is sufficient.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)
  • reviewed 2026-11-09T08:36:11.066Z sha 3664fcb :: needs maintainer review before merge. :: none

Reviewed November 9, 2026, 3:50 AM ET / 08:50 UTC (Revision 2).

@KrasimirKralev

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. labels Nov 9, 2026
@steipete
steipete merged commit 12ebd70 into openclaw:main Nov 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants