Skip to content

build(deps): refresh eligible runtimes and tooling - #329

Merged
steipete merged 12 commits into
mainfrom
build/round20-deps
Nov 14, 2026
Merged

steipete merged 12 commits into
mainfrom
build/round20-deps

Conversation

@steipete

@steipete steipete commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Refresh eligible web, desktop, development, and Go dependencies while retaining the 48-hour release-age policy, runtime minimums, and security overrides. Keep Electron on 43 and pair SQLite 1.62.0 with its required libc 1.80.1. Align the Playwright CI image with the 1.65.0 package.

Pin Virtua to 0.54.0. Four existing scroll/history regressions reproduce with 0.54.1 and 0.54.2, and all four pass with 0.53.6 and 0.54.0 in the same updated dependency set. Hold those two patches until their viewport/resize changes preserve anchoring; keep the assertions unchanged.

The dependency candidate passed the full project gate, a clean Go vulnerability scan, and 25 focused notification/settings browser tests. After CI exposed the scroll regression, only the four failed cases were rerun for the version comparison. Embedded assets are rebuilt, independent Codex P0–P2 reviews cover the final changes, and exact-head CI supplies the full browser and cross-platform checks. The initial CI attempt also exposed an old browser-image pin, which is corrected here.

No application version bump, release, or deployment is included.

@steipete
steipete requested a review from a team as a code owner November 14, 2026 08:15
@clawsweeper

clawsweeper Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T08:44:21.201578Z 76b0d3d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Nov 14, 2026
@clawsweeper

clawsweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs changes before merge.

What this changes

This PR updates web, desktop, Go, and development dependencies, aligns the Playwright container, and regenerates embedded web assets.

Example: Build the Electron desktop application.

  • Before: The build selects Electron 43.8.6.
  • After: The build selects Electron 43.8.8.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Focused maintenance with substantial passing validation, but browser validation and the reason for lifting the prior Virtua hold remain unresolved.
Proof confidence 🦐 gold shrimp (3/6) This maintainer-authored maintenance PR is outside the contributor proof gate; recorded validation supports builds and checks without establishing a successful browser run.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: The shipped application and development environment remain on older dependency releases.
Reason: The maintainer-authored direction authorizes a focused refresh that retains the existing support and security boundaries.

Merge readiness

⛔ Needs changes before merge - 1 item remains

Keep open: this maintainer-directed dependency refresh is absent from main, and no definite introduced code defect was established.

Priority: P3
Reviewed head: f80eb46c883119e4e17b4e1aad96be35788435b5

Before merge

  • Explain or restore the original intent of Virtua version hold - build(deps): refresh web desktop and database dependencies #316: Virtua 0.54.1 failed four existing activity-anchoring and history-restoration browser scenarios, so the maintainer retained 0.53.6; explain why 0.54.2 resolves that concern or retain the known-good selection.

Findings

None.

Provenance

  • Virtua version hold changes intended behavior without addressing why it exists (build(deps): refresh web desktop and database dependencies #316: Virtua 0.54.1 failed four existing activity-anchoring and history-restoration browser scenarios, so the maintainer retained 0.53.6; explain why 0.54.2 resolves that concern or retain the known-good selection.)

Tests

  • Missing end-to-end proof: The exact-head browser suite failed after setup, and unavailable diagnostics leave the failed scenarios and their relationship to the dependency changes unresolved.
Agent review details

How this fits together

Package manifests and lockfiles select browser and desktop dependencies; the web build becomes embedded Go-server assets, while Go modules provide database and authentication libraries.

flowchart LR
  A[Package manifests] --> B[Web build]
  B --> C[Embedded assets]
  C --> D[Go server]
  D --> E[Browser app]
  A --> F[Electron desktop]
  G[Go modules] --> D
  D --> H[Database drivers]
Loading

Technical review

Best possible solution:

Land the focused refresh while preserving the established runtime, security, and scrolling contracts.

Do we have a high-confidence way to reproduce the issue?

This is dependency maintenance; no current application bug was reproduced, and no target code was executed during this read-only review.

Is this the best way to solve the issue?

Updating existing manifests and lockfiles and regenerating assets through the established build owner is appropriately scoped.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 881f92207272.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: Routine dependency maintenance with no demonstrated urgent user-facing regression.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Label justifications:

  • P3: Routine dependency maintenance with no demonstrated urgent user-facing regression.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Classify the failed exact-head browser run and address the earlier Virtua scrolling failures before landing.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 14, 2026, 3:34 AM ET / 08:34 UTC.

@steipete
steipete merged commit 55b55d4 into main Nov 14, 2026
14 of 15 checks passed
@steipete
steipete deleted the build/round20-deps branch November 14, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants