Skip to content

chore: adopt plugin-inspector 0.3.26 - #317

Merged
RomneyDa merged 5 commits into
mainfrom
release/plugin-inspector-0.3.26
Sep 20, 2026
Merged

RomneyDa merged 5 commits into
mainfrom
release/plugin-inspector-0.3.26

Conversation

@RomneyDa

@RomneyDa RomneyDa commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

Crabpot's default packaged Inspector remained on v0.3.25, while its source pin did not include the completed SDK-classification and conversation-contract repairs.

Why This Change Was Made

Pins source and published-package modes to the verified v0.3.26 release, updates their guard, and aligns the operational docs and changelog. No fixture pin, report expectation, workflow, or runtime orchestration changes.

Related release: openclaw/plugin-inspector#88

Evidence

  • Final head: f9cc4a5faabc74b4f5bc345d2cf3688bdb8b4104.
  • Inspector release commit: 6169338410f76e1e7e9f6ec29c65b6007e62d829; reviewed candidate and landed trees are identical.
  • Trusted release workflow passed: https://github.com/openclaw/plugin-inspector/actions/runs/35527920012.
  • Published release: https://github.com/openclaw/plugin-inspector/releases/tag/v0.3.26.
  • npm latest is v0.3.26; registry gitHead is the exact release commit. Published shasum: abe8ab15c27d188105112d4a54d8f297a70f84b1.
  • Source-pin and package-invocation guard: 6 tests passed.
  • Exact landed-source smoke: 59 fixtures, zero breakages.
  • Fresh-cache default published-package smoke: 59 fixtures, zero breakages.
  • Strict published follow-through passes the exact source SHA, v0.3.26 package pin, and public-API migration checks.
  • git diff --check passed.

Fixture Impact

  • Adds or updates fixture manifest entries
  • Updates submodule pins
  • Changes contract or smoke logic
  • Docs only

Dependency source/package pins, their existing guard, and matching release documentation only. Fixture configuration and expectations remain unchanged.

@clawsweeper

clawsweeper Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 20, 2026
@clawsweeper

clawsweeper Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed September 20, 2026, 3:10 PM ET / 19:10 UTC (Revision 4).

ClawSweeper review

What this changes

Updates Crabpot’s Plugin Inspector source and package pins to 0.3.26, aligns documentation, and adjusts report tests for targets with and without conversation-contract coverage.

Merge readiness

✅ Ready for maintainer review

The prior report-test blocker is resolved, and no remaining actionable defect was found. This maintainer-authored adoption remains necessary because current main still pins the published package to 0.3.25.

Priority: P3
Reviewed head: 909c182946e74a82498a70839ef1e17f2eb9c8f0

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused dependency adoption with verified publication provenance and the prior report-test finding resolved.
Proof confidence 🌊 off-meta tidepool Not applicable: The external-contributor proof gate does not apply to this MEMBER-authored PR. Supplied evidence reports source and published CLI smokes over 59 fixtures, plus covered/uncovered report checks; this review verified source contracts and publication metadata without executing target code.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: The external-contributor proof gate does not apply to this MEMBER-authored PR. Supplied evidence reports source and published CLI smokes over 59 fixtures, plus covered/uncovered report checks; this review verified source contracts and publication metadata without executing target code.
Evidence reviewed 8 items Applicable repository policy: Read the complete root AGENTS.md. No nested AGENTS.md or maintainer notes were found. Applied its requirements to align source/package pins, report expectations, and source/package smoke validation.
Introduced change and continuing necessity: The pinned introduction diff changes six files. Main uses source 0e8f55371170bce8dfc5bfe07023c56761b60de0 and package 0.3.25; the branch selects the released 0.3.26 source and package. Fixture configuration, workflow permissions, and loader orchestration are unchanged.
Prior finding resolved: The latest commit replaces unconditional absence assertions with coverage-dependent assertions and explicitly checks warnings and the P1 issue for a disabled target. Its helper requires active/supported status, named tests, and no missing tests. This addresses the previous finding and rank-up request.
Findings None None.
Security None None.

How this fits together

Crabpot checks plugin fixtures against an OpenClaw target using Plugin Inspector. The pinned Inspector source powers compatibility reports, while the published package powers the default CLI smoke check.

flowchart TD
  A[Plugin fixtures] --> C[Plugin Inspector]
  B[OpenClaw target contracts] --> C
  D[Pinned source] --> C
  E[Published package] --> F[CLI smoke check]
  C --> G[Compatibility findings]
  F --> G
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

None.

Technical review

Best possible solution:

Keep source and published-package modes aligned with the released Inspector, with report expectations preserving both covered and uncovered target behavior.

Do we have a high-confidence way to reproduce the issue?

Not applicable to this dependency adoption; source inspection confirms the prior assertion mismatch is addressed, with both target states reported passing by the contributor.

Is this the best way to solve the issue?

Yes. Updating the existing pins and adapting report assertions to the released dependency contract is the narrowest supported approach.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 531798ad84d0.

Labels

Label changes:

  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external-contributor proof gate does not apply to this MEMBER-authored PR. Supplied evidence reports source and published CLI smokes over 59 fixtures, plus covered/uncovered report checks; this review verified source contracts and publication metadata without executing target code.
  • remove status: ⏳ waiting on author: Current PR status label is status: 👀 ready for maintainer look.
  • remove rating: 🦐 gold shrimp: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.

Label justifications:

  • P3: This is a bounded dependency adoption and report-test alignment without an established urgent user-facing failure.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external-contributor proof gate does not apply to this MEMBER-authored PR. Supplied evidence reports source and published CLI smokes over 59 fixtures, plus covered/uncovered report checks; this review verified source contracts and publication metadata without executing target code.

Evidence

What I checked:

  • Applicable repository policy: Read the complete root AGENTS.md. No nested AGENTS.md or maintainer notes were found. Applied its requirements to align source/package pins, report expectations, and source/package smoke validation. (AGENTS.md:12, 909c182946e7)
  • Introduced change and continuing necessity: The pinned introduction diff changes six files. Main uses source 0e8f55371170bce8dfc5bfe07023c56761b60de0 and package 0.3.25; the branch selects the released 0.3.26 source and package. Fixture configuration, workflow permissions, and loader orchestration are unchanged. (scripts/plugin-inspector-source.mjs:7, 909c182946e7)
  • Prior finding resolved: The latest commit replaces unconditional absence assertions with coverage-dependent assertions and explicitly checks warnings and the P1 issue for a disabled target. Its helper requires active/supported status, named tests, and no missing tests. This addresses the previous finding and rank-up request. (test/report.test.mjs:448, 909c182946e7)
  • Dependency contract applies: The report builder imports Plugin Inspector’s public API and delegates fixture classification to inspectCompatibilityFixtureSetConfig, establishing Plugin Inspector as the authoritative contract for the changed assertions. (scripts/report-lib.mjs:37, 909c182946e7)
  • Verified dependency behavior: At the pinned release, conversation-access-hook warnings are suppressed only for active/supported target records with named contract tests and no missing files. The target parser emits both test arrays, matching Crabpot’s revised assertions. (src/fixture-summary.js:718, 6169338410f7)
  • Published dependency provenance: GitHub confirms chore(release): prepare plugin-inspector 0.3.26 plugin-inspector#88 merged at the selected source SHA. Release v0.3.26 is published, and its release workflow succeeded at that SHA. The npm version endpoint independently reports the same gitHead and shasum abe8ab15c27d188105112d4a54d8f297a70f84b1. (package.json:3, 6169338410f7)

Likely related people:

  • vincentkoc: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
  • SebTardif: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (3 earlier review cycles)
  • reviewed 2026-09-20T18:03:28.026Z sha 608d050 :: needs changes before merge. :: none
  • reviewed 2026-09-20T18:12:34.716Z sha f9cc4a5 :: needs changes before merge. :: [P2] Align conversation-warning assertions with the new Inspector
  • reviewed 2026-09-20T18:38:49.555Z sha 690494e :: needs changes before merge. :: [P2] Make conversation-warning assertions conditional on target coverage

@RomneyDa
RomneyDa marked this pull request as ready for review September 20, 2026 18:09
@RomneyDa
RomneyDa requested a review from a team as a code owner September 20, 2026 18:09
@RomneyDa

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 20, 2026
@RomneyDa

Copy link
Copy Markdown
Member Author

Fixed the v0.3.26 report-contract mismatch at exact head 690494e0125d61b86dfe8fcb4c60e9133ee6205f.

Validation against the landed Inspector source and pinned OpenClaw checkout:

  • report contract tests: 9/9 passed
  • full unit suite: 428 tests (416 passed, 12 platform skips)
  • contract smoke: 59/59 fixtures
  • Plugin Inspector smoke: 59 fixtures, 0 breakages
  • generated surface: 0 static missing, 0 runtime missing
  • report/coverage: 249 issues, 217 probes, 0 breakages
  • CI policy: pass
  • complete static suite: 19/19 stages

The regression now asserts that the covered target produces no conversation-access-hook warnings or issues while retaining the other P1 coverage.

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

@RomneyDa

Copy link
Copy Markdown
Member Author

Fixed the uncovered-target review finding at exact head 909c182.

The report test now derives conversation-contract coverage from the target compat record: status is active/supported, at least one contract test is named, and no named tests are missing. Covered targets require zero conversation-access-hook findings; uncovered/disabled targets require the representative warnings and P1 issue.

Validation:

  • covered + disabled/uncovered focused report/source tests: 15/15 passed
  • complete npm test: 428 tests (416 passed, 12 platform skips)
  • git diff --check

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Sep 20, 2026
@RomneyDa
RomneyDa merged commit 36316f3 into main Sep 20, 2026
24 checks passed
@RomneyDa
RomneyDa deleted the release/plugin-inspector-0.3.26 branch September 20, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant