Repository navigation
chore: adopt plugin-inspector 0.3.26 - #317
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 20, 2026, 3:10 PM ET / 19:10 UTC (Revision 4). ClawSweeper reviewWhat this changesUpdates Crabpot’s Plugin Inspector source and package pins to 0.3.26, aligns documentation, and adjusts report tests for targets with and without conversation-contract coverage. Merge readiness✅ Ready for maintainer review The prior report-test blocker is resolved, and no remaining actionable defect was found. This maintainer-authored adoption remains necessary because current main still pins the published package to 0.3.25. Priority: P3 Review scores
Verification
How this fits togetherCrabpot checks plugin fixtures against an OpenClaw target using Plugin Inspector. The pinned Inspector source powers compatibility reports, while the published package powers the default CLI smoke check. flowchart TD
A[Plugin fixtures] --> C[Plugin Inspector]
B[OpenClaw target contracts] --> C
D[Pinned source] --> C
E[Published package] --> F[CLI smoke check]
C --> G[Compatibility findings]
F --> G
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Keep source and published-package modes aligned with the released Inspector, with report expectations preserving both covered and uncovered target behavior. Do we have a high-confidence way to reproduce the issue? Not applicable to this dependency adoption; source inspection confirms the prior assertion mismatch is addressed, with both target states reported passing by the contributor. Is this the best way to solve the issue? Yes. Updating the existing pins and adapting report assertions to the released dependency contract is the narrowest supported approach. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 531798ad84d0. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles)
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Fixed the v0.3.26 report-contract mismatch at exact head Validation against the landed Inspector source and pinned OpenClaw checkout:
The regression now asserts that the covered target produces no @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Fixed the uncovered-target review finding at exact head The report test now derives conversation-contract coverage from the target compat record: status is active/supported, at least one contract test is named, and no named tests are missing. Covered targets require zero Validation:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
What Problem This Solves
Crabpot's default packaged Inspector remained on v0.3.25, while its source pin did not include the completed SDK-classification and conversation-contract repairs.
Why This Change Was Made
Pins source and published-package modes to the verified v0.3.26 release, updates their guard, and aligns the operational docs and changelog. No fixture pin, report expectation, workflow, or runtime orchestration changes.
Related release: openclaw/plugin-inspector#88
Evidence
f9cc4a5faabc74b4f5bc345d2cf3688bdb8b4104.6169338410f76e1e7e9f6ec29c65b6007e62d829; reviewed candidate and landed trees are identical.latestis v0.3.26; registrygitHeadis the exact release commit. Published shasum:abe8ab15c27d188105112d4a54d8f297a70f84b1.git diff --checkpassed.Fixture Impact
Dependency source/package pins, their existing guard, and matching release documentation only. Fixture configuration and expectations remain unchanged.