Skip to content

feat: verify resource collector in source and packed smoke - #351

Merged
vincentkoc merged 1 commit into
mainfrom
feat/plugin-resource-campaign-20260922
Sep 23, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
feat/plugin-resource-campaign-20260922

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

Crabpot smoke checks did not verify Plugin Inspector's public resource collector export in both source and packed-package installations.

User Impact

CI can detect missing collector exports or broken snapshot and resource-delta behavior before consumers rely on them. This checks the collector contract only; it does not measure plugin workload cost.

Why This Change Was Made

Advance the Inspector source pin to e2f36f1cdf943826c37303e3632866e12eaf15ce, containing the collector API, and add opt-in --resources coverage to the existing smoke runner. The source and packed CI lanes select their exact installation explicitly and resolve the public resource-profile export.

A fresh child checks JSON-transported snapshots, a retained 1 MiB Buffer, and a timer added and removed. The runner requires successful command completion and cleanup before retaining the collector report. The npm package pin stays at 0.3.26; older published packages are not claimed to contain this API.

Evidence

  • Reviewed head: 7851786f4e5f94f462ad648d53e24ea4b9ee41b5; frozen base: 407299b17af54c48ffc117c2536097f6c40bcc6e.
  • Tree: ef3a42c85560479fc90ac6b7bf09f372d5eeeb09; full diff SHA-256: c49a860da2753ddb5a4fead6a4406dd8238dbe35fc31dd2adf5390ce4475a491.
  • Fresh full-branch native review through P2 returned exit 0, scoped-clean, correct 0.93, with no findings. Independent final integration review is clean.
  • All four affected JavaScript syntax checks, whitespace and privacy checks passed. The five non-documentation files remain byte-identical to the preceding implementation. Removing this change's exact README and changelog additions reconstructs the frozen base byte-for-byte; landed source and generated reports are preserved.
  • Exact-head required Check passed, including Ubuntu, macOS, Windows, container checks, and the required aggregate. The current Windows pass does not establish a repair for the historical failures below.
  • The Ubuntu execution log records all eight focused Inspector tests passing, explicit source selection, npm pack/install, explicit packed-package selection, and both resource smoke passes. The source/packed step completed in 23 seconds.
  • Current-head collector artifact: SHA-256 77aec050a7cd9bb1045588b6cd1cea917a596153a7a8030554234d197d8de340. Source receipt SHA-256 d5c323d7052237e86db23bf07b2dc4ec5dae38bc54634b2ca9bbe8d80ca38233; packed receipt SHA-256 956ef77913fe8f3e01268af90543252ee6b479bc75cb0289d9897a4fcd5bfbe1. Both record Node 24.21.0/Linux x64, stable child/thread identities, a 1 MiB ArrayBuffer increase, and timer +1/-1 with the resource map restored. Independent receipt audit verified exact-head artifact binding and every raw-to-delta value. This is collector-contract verification, not Gateway workload or performance qualification.
  • Current-head ClawSweeper revision 12 reports no actionable findings or remaining rank-up moves.
  • Historical proof at 5c5c8012a1295ec99a687932176de5e07d6730e6: Ubuntu job passed all eight focused tests and completed the source/packed smoke step in 24 seconds. CI artifact, SHA-256 9ff82a670a6188603f4ccb480eaf5204109d0e6d618268d5a8ff41ae1cb205aa, was verified against that head. Both collector receipts recorded Node 24.21.0/Linux x64, stable child/thread identities, a 1 MiB ArrayBuffer increase, and timer +1/-1. Independent audit verified the archive binding, source-to-packed execution chain, and every reported snapshot delta. This is prior-head collector-contract proof, not qualification of the new head.
  • Historical required failure remains unresolved: Windows job failed during import-time Inspector checkout startup in capture-contracts.test.mjs and ci-policy.test.mjs: EOWNERSTART (command supervisor startup timed out); the latter also reported that command cleanup was not confirmed. These were failed startup admissions with an unproven root cause, and the required aggregate failed. This integration does not repair or waive those failures.
  • No dependency installation or duplicate heavy local proof was performed for this integration.
  • 123 changed lines: production scripts +17/-3 (net +14), CI +2/-2, tests/fixtures +74/-1, documentation/changelog +24. Production growth adds the public collector-contract smoke capability to the existing command owner.

Fixture Impact

  • Adds or updates fixture manifest entries
  • Updates submodule pins
  • Changes contract or smoke logic
  • Docs only

Fixture Verification

  • npm test
  • node scripts/sync-fixtures.mjs --check
  • node scripts/run-contract-smoke.mjs
  • Strict fixture smoke, if submodules were materialized

Notes

No Gateway workload, memory-release, peak-memory or leak claim. CPU/RSS observations belong to the child process; the other memory/resource observations belong to its main thread. An empty child environment is not a network sandbox. No release or production deployment is included.

@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@vincentkoc
vincentkoc marked this pull request as ready for review September 22, 2026 12:50
@vincentkoc
vincentkoc requested a review from a team as a code owner September 22, 2026 12:50
@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 22, 2026
@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed September 23, 2026, 9:08 AM ET / 13:08 UTC (Revision 12).

ClawSweeper review

What this changes

Adds optional resource-collector checks to Plugin Inspector’s source and packed-package smoke runs, advances the source pin, and documents the measurements’ limits.

Merge readiness

✅ Ready for maintainer review

Keep open: this adds useful coverage absent from main, and no introduced correctness or security defect was found. Historical collector proof remains relevant because all five implementation and workflow files are unchanged.

Priority: P2
Reviewed head: 7851786f4e5f94f462ad648d53e24ea4b9ee41b5

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused implementation with relevant historical runtime evidence and no actionable introduced defect.
Proof confidence 🐚 platinum hermit (4/6) ✨ media proof bonus Sufficient (linked_artifact): Historical source/packed execution and supplied Linux receipts exercise the real collector through the smoke runner, showing the retained allocation and timer deltas; all five relevant files match this head. Artifact contents could not be independently reopened because storage egress was blocked. Current-head CI remains pending, and no stored-data contract changes.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Verified Sufficient (linked_artifact): Historical source/packed execution and supplied Linux receipts exercise the real collector through the smoke runner, showing the retained allocation and timer deltas; all five relevant files match this head. Artifact contents could not be independently reopened because storage egress was blocked. Current-head CI remains pending, and no stored-data contract changes.
Evidence reviewed 10 items Repository policy: Read the full root AGENTS.md; no nested AGENTS.md or maintainer-notes directory was found. Applied the fixture-driven, credential-free validation and Inspector pin guidance.
Introduced behavior and cleanup: The pinned base-to-head diff adds an explicitly selected collector child, checks execution and cleanup errors before saving its JSON, and enables it in the existing source/packed workflow. No workflow permissions, action references, install hooks, or dependency lockfiles change.
Concrete dependency contract: The new fixture resolves @openclaw/plugin-inspector/resource-profile through the selected package’s public exports map, then checks JSON-transported snapshots, retained allocation and timer deltas. This establishes the dependency contract inspected in this review.
Findings None None.
Security None None.

How this fits together

Crabpot checks OpenClaw plugin compatibility using Plugin Inspector. Its smoke runner exercises selected source or installed packages and saves reports that CI uses to detect broken contracts.

flowchart LR
  A[Source checkout] --> C[Smoke runner]
  B[Packed installation] --> C
  C --> D[Public collector export]
  D --> E[Child snapshots and timer checks]
  E --> F[Completion and cleanup checks]
  F --> G[Resource report and CI result]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Production and test delta Production +17/-3; tests and fixtures +74/-1 The net 14 production lines add the stated collector-contract capability using the existing command owner.
Package coverage 2 installation modes; 2 new tests Source and packed installations exercise the public export, with positive collector and missing-export coverage.

Technical review

Best possible solution:

Keep collector-contract verification in the existing smoke runner, with explicit package selection and separate reporting from plugin workload measurements.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this adds smoke coverage rather than repairing a reproduced product failure; current main demonstrably lacks the collector checks.

Is this the best way to solve the issue?

Yes: extending the existing runner and resolving the public package export checks the intended packaging contract without introducing another profiler.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 407299b17af5.

Labels

Label changes:

No label changes.

Label justifications:

  • P2: This is a bounded improvement to dependency-contract validation with no demonstrated urgent user regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (linked_artifact): Historical source/packed execution and supplied Linux receipts exercise the real collector through the smoke runner, showing the retained allocation and timer deltas; all five relevant files match this head. Artifact contents could not be independently reopened because storage egress was blocked. Current-head CI remains pending, and no stored-data contract changes.
  • proof: sufficient: Contributor real behavior proof is sufficient. Historical source/packed execution and supplied Linux receipts exercise the real collector through the smoke runner, showing the retained allocation and timer deltas; all five relevant files match this head. Artifact contents could not be independently reopened because storage egress was blocked. Current-head CI remains pending, and no stored-data contract changes.

Evidence

What I checked:

Likely related people:

  • unknown: The claimed source-line change could not be verified from bounded local history. (role: source history unknown; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (11 earlier review cycles; latest 8 shown)
  • reviewed 2026-09-22T15:19:55.333Z sha 114169b :: needs maintainer review before merge. :: none
  • reviewed 2026-09-22T15:58:50.507Z sha 3c6a597 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-22T16:10:18.449Z sha 41707e1 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-22T23:13:05.670Z sha 15bf6a4 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-23T06:03:30.665Z sha 5c5c801 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-23T06:11:19.108Z sha 5c5c801 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-23T06:25:38.995Z sha 5c5c801 :: needs maintainer review before merge. :: none
  • reviewed 2026-09-23T12:57:54.237Z sha 7851786 :: needs maintainer review before merge. :: none

@vincentkoc
vincentkoc force-pushed the feat/plugin-resource-campaign-20260922 branch from 41d693f to 114169b Compare September 22, 2026 15:15
@vincentkoc

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

Please review exact head 114169b after resolving the main-branch pin conflict. The collector revision contains main's pin; all eight focused source/consumer tests passed after rebase. Fresh CI is running.

@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

@vincentkoc

Copy link
Copy Markdown
Member Author

@clawsweeper re-review exact head 3c6a5975f51b962bbed1994a3ae6a2c7850228ce. Required base update onto merged coverage PR only; the six-file patch remains 122 changed lines. Eight focused tests passed in 1.915s.

@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

@vincentkoc
vincentkoc force-pushed the feat/plugin-resource-campaign-20260922 branch 2 times, most recently from 3c6a597 to 41707e1 Compare September 22, 2026 16:05
@vincentkoc

Copy link
Copy Markdown
Member Author

@clawsweeper re-review exact head 41707e156edda0709f91eba584e7665bfcc645c7. Required base-only update incorporates the generated dashboard refresh. The five non-documentation changed-file blobs are identical to reviewed 3c6a5975f51b962bbed1994a3ae6a2c7850228ce; scope remains122 lines. Fresh CI is running.

@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

@vincentkoc
vincentkoc marked this pull request as draft September 22, 2026 23:08
@vincentkoc
vincentkoc force-pushed the feat/plugin-resource-campaign-20260922 branch 2 times, most recently from 15bf6a4 to 5c5c801 Compare September 23, 2026 05:58
@vincentkoc
vincentkoc marked this pull request as ready for review September 23, 2026 06:05
@clawsweeper clawsweeper Bot added the proof: sufficient Contributor real behavior proof is sufficient. label Sep 23, 2026
@vincentkoc
vincentkoc marked this pull request as draft September 23, 2026 12:53
@vincentkoc
vincentkoc force-pushed the feat/plugin-resource-campaign-20260922 branch from 5c5c801 to 7851786 Compare September 23, 2026 12:53
@vincentkoc
vincentkoc marked this pull request as ready for review September 23, 2026 13:04
@vincentkoc
vincentkoc merged commit aa2273e into main Sep 23, 2026
22 of 24 checks passed
@vincentkoc
vincentkoc deleted the feat/plugin-resource-campaign-20260922 branch September 23, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant