Skip to content

chore(deps): bump @tencent-weixin/openclaw-weixin from 2.4.9 to 2.4.10 in /plugins/openclaw-weixin - #475

Closed
dependabot[bot] wants to merge 5 commits into
mainfrom
dependabot/npm_and_yarn/plugins/openclaw-weixin/tencent-weixin/openclaw-weixin-2.4.10
Closed

dependabot[bot] wants to merge 5 commits into
mainfrom
dependabot/npm_and_yarn/plugins/openclaw-weixin/tencent-weixin/openclaw-weixin-2.4.10

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 14, 2026

Copy link
Copy Markdown
Contributor

Bumps @tencent-weixin/openclaw-weixin from 2.4.9 to 2.4.10.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps @tencent-weixin/openclaw-weixin from 2.4.9 to 2.4.10.

---
updated-dependencies:
- dependency-name: "@tencent-weixin/openclaw-weixin"
  dependency-version: 2.4.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 14, 2026
@clawsweeper

clawsweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

…rn/plugins/openclaw-weixin/tencent-weixin/openclaw-weixin-2.4.10
@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 14, 2026
@clawsweeper

clawsweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge.

What this changes

This PR updates the Weixin fallback to 2.4.10, refreshes Zod to 4.6.5, and adds an Unreleased credit.

Example: Crabpot uses the committed Weixin fallback package.

  • Before: The fixture selects Weixin 2.4.9 with Zod 4.4.3.
  • After: The fixture selects Weixin 2.4.10 with Zod 4.6.5, without installing OpenClaw peers into its lock.

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The narrow patch has no established code defect and reported config-preservation coverage, but authorization proof stops before the downstream effects required to clear its security boundary.
Proof confidence 🦪 silver shellfish (2/6) Real behavior proof is necessary before merge. See Before merge.
Patch quality 🦐 gold shrimp (3/6) Security review found an item that needs attention.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Crabpot's committed fallback remains behind the published Weixin patch that updates OpenClaw SDK compatibility.
Reason: The update serves the existing compatibility fixture, and recorded member direction approves retaining its repaired lock and changelog.

Merge readiness

⛔ Blocked before merge - 3 items remain

This PR remains useful and is not implemented on main; the repaired lock is sound, and the member-approved manual landing path resolves the earlier changelog finding.

Priority: P2
Reviewed head: f87c823e20f50e18713a183a7d24d53c592eac25

Before merge

  • Add real behavior proof - Authority-chain proof required: the member's exact-head qualification reports 24 passing admission cases using published processors and the frozen registered SDK, but explicitly substitutes dispatch/session recording and outbound fetch. Provide redacted logs or terminal output through the real downstream command and transport owners for an allowed sender and the nearest forbidden, cross-account, ownerless, and revoked or reassigned principals, showing rejection before final I/O. Distinguish inherited local-command ordering and in-flight snapshots from changes introduced by 2.4.10; they are not new findings against this PR. After adding proof, update the PR body, then request a new review with @clawsweeper re-review. The PR author or someone with repository write access can request it.
  • Resolve security concern: Validate command authority through its downstream consumer - The new helper passes ingress command authorization into CommandAuthorized, including false for ownerless control commands; the supplied qualification records that handoff but substitutes its terminal consumer, so it cannot establish that the real consumer prevents unauthorized execution.
  • Resolve merge risk - The replacement authorization boundary passes command authority downstream, but enforcement for forbidden, cross-account, ownerless, and revoked principals at real command execution and outbound effects remains unestablished.

Findings

  • [medium] Validate command authority through its downstream consumer — plugins/openclaw-weixin/package.json:7

Tests

  • Missing end-to-end proof: The reported admission harness does not exercise actual downstream command authorization and outbound effects for allowed, forbidden, cross-account, ownerless, and revoked principals.
Agent review details

How this fits together

Crabpot materializes configured plugin artifacts into isolated workspaces with a separately supplied OpenClaw host, then produces compatibility captures and reports.

flowchart LR
  A[Fixture configuration] --> B[Npm artifact selection]
  B --> C[Weixin package]
  C --> D[Isolated workspace]
  E[Frozen OpenClaw host] --> D
  D --> F[Compatibility captures]
  F --> G[Reports]
Loading

Technical review

Best possible solution:

Retain the repaired fallback update and approved changelog, then establish authorization enforcement through the real downstream effect owners.

Do we have a high-confidence way to reproduce the issue?

This is a dependency refresh rather than a reproduced Crabpot bug; source inspection confirms the package changes, and qualification reports admission checks without demonstrating a new authorization failure.

Is this the best way to solve the issue?

Updating the existing fixture pin and minimal lock preserves the established acquisition and host boundaries without adding a competing implementation.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against d300f1bf92fb.

Merge-risk options

Maintainer options:

  1. Hold for final-effect authorization evidence (recommended)
    Keep the update open until scoped evidence covers the actual downstream authorization owners; retain the existing member-approved manual landing path.

Provenance checked

Testing

Proof path: in-process harness.

Security

Needs attention: No introduced bypass was established, but the changed authorization handoff still needs final-effect validation.

Evidence

Security concerns:

  • [medium] Validate command authority through its downstream consumer — plugins/openclaw-weixin/package.json:7
    The new helper passes ingress command authorization into CommandAuthorized, including false for ownerless control commands; the supplied qualification records that handoff but substitutes its terminal consumer, so it cannot establish that the real consumer prevents unauthorized execution.
    Confidence: 0.97

What I checked:

  • Pinned change and current main: The verified introduced diff changes only the changelog, fixture manifest, and fixture lock; main still selects Weixin 2.4.9. The new lock contains four package entries and excludes the OpenClaw peer graph. (plugins/openclaw-weixin/package-lock.json:15, f87c823e20f5)
  • Applicable repository policy: The complete root AGENTS.md requires fixture-driven acquisition, credential-free default checks, and host-owned OpenClaw dependencies; no nested AGENTS.md or maintainer-notes directory was present. (AGENTS.md:12, f87c823e20f5)
  • Recorded manual landing decision: A repository member explicitly retained the changelog and selected manual review in chore(deps): bump @tencent-weixin/openclaw-weixin from 2.4.9 to 2.4.10 in /plugins/openclaw-weixin #475 (comment). The optional auto-merge job's CHANGELOG.md rejection therefore does not require removing the entry or changing automation. (.github/workflows/dependabot-auto-merge.yml:87, f87c823e20f5)
  • Updated qualification and its explicit boundary: chore(deps): bump @tencent-weixin/openclaw-weixin from 2.4.9 to 2.4.10 in /plugins/openclaw-weixin #475 (comment) reports 24 passing old/new admission cases through the registered source SDK and preserved config/account/pairing data, while explicitly substituting terminal dispatch, session recording, and outbound fetch and excluding downstream command execution. (f87c823e20f5)
  • Published dependency contents: Read-only inspection of both npm tarballs verified their SHA-512 integrity against the committed locks. Source and compiled changes replace inbound authorization helpers, introduce the channel-ingress SDK call, change config mutation, and add typing-import fallback; dependencies and lifecycle scripts remain unchanged. The package changelog describes OpenClaw compatibility as the purpose. Registry metadata supplies no repository or gitHead, so no upstream commit is attributed. (package/src/messaging/authorization.ts:24)
  • Previous findings and feature history: The earlier host-peer lock defect is repaired. The changelog finding is superseded by the member's explicit decision. Main history identifies Vincent Koc's fixture and security work and Peter Steinberger's compatible refresh in build(deps): refresh compatible fixtures and repair telemetry audit #295. Following the manifest reaches its creation commit and then an unavailable predecessor blob; this does not prevent verifying retained lines or recent ownership. (plugins/openclaw-weixin/package.json:7, d300f1bf92fb)

Likely related people:

  • Vincent Koc: Raw commit 90fe18e adds plugins/openclaw-weixin/package.json:19 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 90fe18e5c020; files: plugins/openclaw-weixin/package.json)

Labels

Label changes:

  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • remove rating: 🧂 unranked krab: Current PR rating is rating: 🦪 silver shellfish, so this older rating label is no longer current.

Label justifications:

  • P2: This is normal fixture maintenance with a limited compatibility-testing blast radius and no demonstrated urgent Crabpot regression.
  • merge-risk: 🚨 security-boundary: The selected artifact changes inbound sender and command authorization, while supplied qualification explicitly stops before actual downstream command execution and outbound effects.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Add final-effect proof for forbidden and cross-account senders and ownerless command authority, including revocation or reassignment before I/O through the real downstream owners.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (2 earlier review cycles)
  • reviewed 2026-10-14T17:19:10.435Z sha 0b9592d :: needs changes before merge. :: [P2] Regenerate the fixture lock without automatic OpenClaw peers
  • reviewed 2026-10-14T18:17:30.072Z sha 0add735 :: needs real behavior proof before merge. :: [P2] Remove the changelog addition from this Dependabot update

Reviewed October 14, 2026, 11:05 PM ET / October 15, 2026, 03:05 UTC (Revision 3).

@vincentkoc

Copy link
Copy Markdown
Member

Updated this PR’s original Dependabot branch to 0add735a23eb6e8e20f21a9b98008e3c19767771. Kept Weixin 2.4.10 and Zod 4.6.5, regenerated the lock with the documented --package-lock-only --ignore-scripts --legacy-peer-deps boundary, and restored stale generated reports to current main. The fixture lock now has four entries and no vendored OpenClaw peer graph. Added an Unreleased credit for Dependabot.

Qualification: run 38611002012 passed against frozen host 10bb24270d8dad0f85781980248c5ba9a1d5cd71; its temporary request commit 863412b1782ef432bb38aaf3beb15e52bb19fa31 adds only the existing CI request to this candidate. Static checks and all 14 isolated execution steps completed. Source and compiled entry points both captured registerChannel using the mock SDK. Synthetic results were 0 passed, 0 failed, 2 blocked because channel runtime execution requires an opt-in harness. This does not establish native auth/config/typing or live Weixin compatibility.

Both workspace audits returned raw exit 1: 8 advisories (3 critical, 3 high, 2 moderate) outside the repaired four-entry fixture lock. Both plugin versions declare identical development/workspace dependencies. The artifact omits the installed lock, so it does not establish exact installed-host resolution or audit the frozen host’s dependency graph. These warnings and the existing policy remain unchanged. The temporary CI branch was deleted and its absence verified. Independent source/lock review and the scoped metadata autoreview found no actionable issue; normal PR CI and fresh exact-head ClawSweeper review are still required.

@vincentkoc

Copy link
Copy Markdown
Member

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 14, 2026
@vincentkoc

Copy link
Copy Markdown
Member

Holding this update at 0add735a23eb6e8e20f21a9b98008e3c19767771 pending native behavior proof. The repaired four-entry fixture lock preserves Weixin 2.4.10 and removes the accidentally installed peer-host graph. Required CI is green; the optional auto-merge job rejects the changelog file. We retain that entry and use manual review.

Four isolated qualification attempts stopped before any of the 24 planned old/new admission cases or config-preservation checks ran. These are test-environment failures, not demonstrated plugin regressions or passing runtime proof. Existing mock-SDK qualification remains 0 passed / 0 failed / 2 blocked.

Source review identifies inherited limits: local transport commands and media handling precede admission, and in-flight messages retain their earlier allowlist snapshot in both versions. These are not new regressions. Native proof must distinguish plugin admission from full Gateway command execution.

Unblock: demonstrate allowed, forbidden, cross-account, revoked-before-call and ownerless behavior through the real registered SDK, plus preservation of existing config/account/pairing data during reload; then obtain fresh required CI on the strict current base and an exact-head ClawSweeper review.

Audit warnings remain: eight findings outside the four-entry fixture lock; the captured installed workspace graph was insufficient to attribute them precisely. No releases performed.

All four temporary qualification leases were released.

@vincentkoc

Copy link
Copy Markdown
Member

Qualification update for f87c823e20f50e18713a183a7d24d53c592eac25 (merges current main d300f1b). The three-file change preserves the qualified four-entry lock: Weixin 2.4.10, Zod 4.6.5, and no installed OpenClaw peer graph. Both changelog entries and all current-main fixture/report content are retained. Thanks @dependabot.

Actual published 2.4.9 and 2.4.10 message processors were exercised with the registered source SDK at frozen OpenClaw 10bb24270d8dad0f85781980248c5ba9a1d5cd71, isolated state, and denied external network. All 24 admission cases passed, including allowed/unpaired/cross-account senders, absent-before-call authorization, persisted-owner fallback, and ownerless command flags. The new config writer persisted its timestamp while preserving unrelated operator fields and account/pairing bytes. Vitest reported 1/1 test passed; the test child exited 0.

This proves plugin admission and recorded handoff, not full Gateway or live Weixin behavior: terminal dispatch/session recording and outbound fetch were substituted; no host-principal, downstream command execution, media, or live typing claim is made. In-flight authorization snapshots and pre-authorization local commands remain inherited behavior in both versions; /echo was explicitly observed.

The run's outer status remains 1: its receipt parser missed ANSI-prefixed JSON. Independently checking the immutable capture after ANSI-only normalization recovered all 24 unique cases and the config receipt, without rerunning or changing assertions. The isolated unit and lease were released.

The earlier eight raw workspace audit advisories remain recorded outside the four-entry fixture lock. Both versions declare identical development dependencies; the installed host graph was not captured, so no exact host-resolution or zero-security claim is made.

Metadata autoreview is clean. The meaningful changelog remains; its optional Dependabot auto-merge allowlist failure does not replace required checks. Fresh required CI and exact-head ClawSweeper review remain necessary before landing.

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Oct 15, 2026
steipete added a commit that referenced this pull request Oct 15, 2026
Patch smol-toml, OpenTelemetry core, and qs in the Codex and TencentDB fixture locks while retaining qualified plugin versions. Accept only Node's exact optional TypeScript warning before TencentDB's known missing-module diagnostic, keeping unrelated failures strict and the captured fixture LF-stable on Windows.

Fold in the qualified Weixin 2.4.10 and Zod 4.6.5 update from #475, retaining its four-entry fixture lock without installing OpenClaw host peers. Preserve the native admission/config proof limitations documented there.

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
steipete added a commit that referenced this pull request Oct 15, 2026
Patch smol-toml, OpenTelemetry core, and qs in the Codex and TencentDB fixture locks while retaining qualified plugin versions. Accept only Node's exact optional TypeScript warning before TencentDB's known missing-module diagnostic, keeping unrelated failures strict and the captured fixture LF-stable on Windows.

Fold in the qualified Weixin 2.4.10 and Zod 4.6.5 update from #475, retaining its four-entry fixture lock without installing OpenClaw host peers. Preserve the native admission/config proof limitations documented there.

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@steipete

Copy link
Copy Markdown
Contributor

Consolidated into #503 with Weixin 2.4.10, Zod 4.6.5, and the four-entry lock that keeps OpenClaw host peers out of the fixture graph. Vincent's and Dependabot's contributions are credited in the changelog and commit.

The prior native admission/config proof and its limits remain linked from #503. The combined change received a fresh independent P0–P2 review and passed the protected current-main merge gate; this does not broaden the recorded proof into live Gateway, downstream command, media, or provider compatibility.

@steipete steipete closed this Oct 15, 2026
@dependabot @github

dependabot Bot commented on behalf of github Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/plugins/openclaw-weixin/tencent-weixin/openclaw-weixin-2.4.10 branch October 15, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants