Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

- Publish checked CI reports once and summarize only current-job outputs, preserving failed or interrupted coverage without rerunning fixture preparation.
- Include bounded startup-phase observations on command failures without changing startup limits, native admission, or cleanup guarantees.
- Avoid Windows command startup failures caused by per-command compiler and JSON cmdlet loading, preserving the startup budget, atomic Job admission and confirmed cleanup before checkout reuse. Thanks @vincentkoc.
- Arm Windows helper cancellation before request parsing so owner loss or startup expiry cannot leave a parser-blocked helper running.
- Preserve exclusive Plugin Inspector checkout ownership across long installs and unconfirmed command cleanup; fail bounded lock contention without stealing another installer's lock.
- Preserve the Windows command controller's parent environment when a caller supplies a restricted target environment, without changing the target's environment or cleanup guarantees.
Expand Down
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ not proof of process-group extinction.
Failed commands include a bounded `error.startupTrace` with fixed phase names,
emission timestamps (`atMs`) and parent observation timestamps (`observedAtMs`).
These are same-host wall-clock milliseconds, not CPU measurements or deadline
extensions. Windows phases distinguish parsing, bootstrap containment, compilation
extensions. Windows phases distinguish native binding preparation, request parsing
and native process creation. Missing later phases remain unknown; a phase marker
never proves Job extinction. The parent retains received phases if its Worker dies.
Contextual timeout errors retain the original error as `cause`.
Expand All @@ -229,8 +229,10 @@ removing `.crabpot/plugin-inspector/.checkout.lock` and retrying preparation.

Windows requires 64-bit Windows 10/Server 2016 or newer and Windows PowerShell:
commands enter their private Job at creation, and setup failures never fall back
to uncontained execution. A separate helper Job contains bootstrap compiler
children too. Native Git runs directly; only batch commands use `cmd.exe`.
to uncontained execution. Native bindings and framework JSON serialization prepare
without loading cmdlets or starting a compiler; the parent then issues one request.
A definite failed admission releases checkout custody only after setup cleanup,
helper closure and control-pipe drain. Missing or invalid terminal receipts retain it. Native Git runs directly; only batch commands use `cmd.exe`.
Windows Jobs retain owner-loss cleanup independently of the Worker.
This process ownership is not a sandbox for hostile plugin code.

Expand Down
253 changes: 0 additions & 253 deletions scripts/owned-command-windows.cs

This file was deleted.

Loading
Loading