Repository navigation
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. What this changesThis PR adds Windows workflows and diagnostic scripts to observe command-supervisor startup, native process activity, and bounded stack captures. Example: A Windows helper exceeds the existing 10-second startup deadline before connecting.
Review scores
ProductKind: Test only · Worth it: Yes · Fix scope: Partial Merge readiness⛔ Needs changes before merge - 1 item remains Keep open: this maintainer-led diagnostic draft supports an unresolved Windows startup investigation and explicitly remains held from landing. Priority: P2 Before merge
Findings
Tests
Agent review detailsHow this fits togetherCrabpot's static-suite and profiler commands use a shared command supervisor; these optional diagnostics instrument that existing owner and retain observations as GitHub Actions artifacts. flowchart TD
A[Windows diagnostic workflow] --> B[Startup controls or cold suite]
B --> C[Existing command supervisor]
C --> D[PowerShell helper]
D --> E[Native command]
C --> F[Pipe observations and file markers]
G[Native monitor and debugger] --> D
F --> H[Diagnostic artifacts]
G --> H
Technical reviewBest possible solution: Make incomplete synthetic monitoring fail explicitly, then retain the bounded investigation until attributable evidence supports a repair in the existing supervisor. Do we have a high-confidence way to reproduce the issue? No deterministic reproduction of the natural startup stall is established: real Windows failures are recorded, but the hosted controls and cold-import comparison did not reproduce them; this review executed no target code. Is this the best way to solve the issue? Bounded observation at the existing command owner is appropriate for the approved investigation, but it supplies diagnostics rather than a startup repair. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 4c40f7f5e154. TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 2:53 AM ET / 06:53 UTC. |
| - name: Prepare pinned Microsoft console debugger without PowerShell warmup | ||
| shell: bash | ||
| run: python .crabpot/windows-diagnostic-tools/scripts/prepare-windows-debugger.py "$RUNNER_TEMP/crabpot-debugger" | ||
| - name: Reproduce the actual cold CI import with native observations |
Investigate the intermittent Windows command-supervisor startup failure in #305. This is a diagnostic draft, not a production repair. No startup deadline, retry policy, admission boundary, or production helper source change is proposed. #569 remains held pending the startup investigation. Related work and evidence: @vincentkoc, #541, #568.
Historical failure and commit range
Main 39300406644 failed during the first Inspector
git init. Worker entry arrived at +51 ms and helper spawn at +60 ms; neither bootstrap stderr nor a control-pipe connection was observed before the 10-second deadline. The helper closed under SIGTERM withrequestIssued: false. The first profilercontract-capturesample in #568's run recorded the same observation boundary duringgit rev-parse. Missing bootstrap does not prove the script never entered, since bootstrap itself uses stderr.The last green main was 39215227316,
de5d707b4a2cf864522c7689017c170bfc577fc1. The intervening commits are dashboard output, #541's diagnostics, and #566's fixture/CI changes. The green and startup-failing runs used Node 24.21.0 and image20261007.264.1; no causal commit or version regression is established. Issue #305 predates this range.Both attempts of main run 39353237234 passed the ordinary tests and separately exhausted the 225-minute static-suite allowance. The last green suite took about 227 minutes. That supports #569's CI headroom independently of the startup failure.
Native Windows evidence
The initial latency summarizer required exact timestamp equality and omitted snapshots written one millisecond after helper-spawn, including last-green's first cold launch. The corrected same-parent, unique initial-snapshot correlation accounts for every inspected command with a helper-spawn phase. The values above are corrected; test pass/fail results never changed.
Diagnostic boundaries and results
The instrumentation preserves original static-suite commands and target deadlines. It records file entry/pipe markers, pipe byte counts, and native process/thread/handle/memory counters. Stack capture uses noninvasive, non-suspending
-pvr, is bounded, and excludes copied timeout fixtures. It requests no arguments, locals, environment dumps, or memory dumps. Early monitor loss makes evidence incomplete. Runtime source instrumentation is restored after the run.Trial 6 exposed a debugger command-delivery bug:
.sympathconsumed the semicolon-separated remainder as a path, so the requested full stacks did not execute. The latest branch uses-yand a command file with separate lines, plus a post-workload synthetic check for executed stack commands and detach with the target still alive. A single automatic instruction display is not a substitute for the missing stacks.Additional experiments:
workspace-plan; the final raw log proved that stage completed normally and the run had advanced into profiling. Its first 20 static stages completed, and 235 recorded original-owner commands had no unexpected startup failure (maximum READY 2,713 ms). The cancellation is not failure evidence. Its debugger predates the command-file correction.20261018.275.1. The target and native monitor exited zero; debugger verification passed. Across 293 original-owner commands, error outcomes were expected test controls; owner-start to READY median/max was 561/2,502 ms. Native sampling completed with 52,054 observations, maximum gap 366 ms, and 4,216 MiB maximum aggregate private memory. No natural slow-start capture was triggered. Retained artifact.Earlier full-context run 39564565856 was intentionally cancelled because PowerShell-based signature verification could prewarm startup components. The replacement uses pinned hashes of the previously signature-verified Microsoft debugger files. That cancellation and the earlier corrected LF/CRLF/debugger setup attempts are not natural startup failures.
Validation: actionlint, JavaScript/Python syntax checks and LF/CRLF probe preparation pass. Unchanged local ownership tests: 16 pass, 26 Windows-only skips. Diagnostic changes received independent P0–P2 autoreview; identified observer defects were fixed and re-reviewed. Investigation commits intentionally skip broad CI. Any production repair still requires regression coverage, exact-head CI, and Windows success on merged main.
Outcome
Root cause remains unresolved after the complete pipeline, sixteen fresh cold-runner attempts, an unmodified-source control, and warm helper controls. Independent assessment found no supported production fix or workaround. No production code, merge, or release was made. Main remains at
4c40f7fwith its latest Check failed for the separate 225-minute budget. #569 stays behind the requested root-fix prerequisite; merged-main Windows success has not been achieved. Keep this as an investigation draft and retain #305 as the incident.