Skip to content

build(deps): patch newly disclosed fixture vulnerabilities - #603

Merged
steipete merged 1 commit into
mainfrom
fix/round16-security-followup
Oct 24, 2026
Merged

steipete merged 1 commit into
mainfrom
fix/round16-security-followup

Conversation

@steipete

Copy link
Copy Markdown
Contributor

New advisories reached the registry between #602's successful audit and its post-merge run. Patch the mutable fixture dependencies for Zod, Undici, body-parser, and MSAL, covering 17 new alerts while retaining every reviewed plugin version, source ref, and host pin.

Teams needs MSAL Node 7.1.1 for the patched release. Its direct and Teams SDK consumers share that version; a synthetic client-credentials flow and Teams Apps import pass. Weixin retains its four-entry lock and the repository's existing legacy-peer-deps policy, avoiding an unintended host installation.

Validation: fresh Linux installs and dependency/security proof, exact patched-version assertions, HAPI's host/SDK/p-limit checks, MSAL synthetic authentication, and independent P0–P2 review. The final small Weixin lock also passed a local fresh install, schema check, and audit under nice 19. Documentation and the Unreleased changelog are updated.

The other 26 new alerts have verified publisher-bundle limitations: the latest tarballs still ship the affected bytes, which overrides cannot replace. Those alerts were separately dismissed with artifact-specific evidence. The security gate remains enabled.

@steipete
steipete requested a review from a team as a code owner October 23, 2026 23:57
@clawsweeper

clawsweeper Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T23:58:50.176472Z 48dc6fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 24, 2026
@clawsweeper

clawsweeper Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR updates dependency overrides and locks for seven fixtures while preserving plugin versions, source references, and host pins.

Example: Install the committed Microsoft Teams fixture.

  • Before: The lock selects MSAL Node 6.0.1 and a separate Teams SDK copy at 5.6.0.
  • After: Both consumers resolve MSAL Node 7.1.1.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused dependency repair with verified published artifacts, preserved ownership boundaries, and no actionable findings; runtime-artifact inspection was limited by the environment.
Proof confidence 🌊 off-meta tidepool Not applicable: The supplied maintainer-authored classification exempts ordinary contributor proof gating; the body records Linux fresh installs and synthetic MSAL authentication, but the linked portal is inaccessible here and its provider and runtime results could not be independently verified.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Committed fixture installations select dependencies reported affected by newly disclosed advisories.
Reason: The supplied maintainer-authored classification establishes direction, and the change follows existing fixture-security maintenance while retaining reviewed plugin and host choices.

Merge readiness

✅ Ready for maintainer review

Keep open: current main still contains the older dependencies, and this focused security refresh has no actionable findings.

Priority: P2
Reviewed head: 48dc6fb84b3de4c7bd04bf3e18fbaacdb2057dd2

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: The linked fresh-install and synthetic MSAL runtime artifacts could not be inspected because the proof host is blocked.
Agent review details

How this fits together

Crabpot fixture manifests and locks select npm dependency graphs for isolated plugin workspaces, which feed compatibility checks and the fixture-security gate.

flowchart LR
  A[Fixture configuration] --> B[Fixture package manifests]
  B --> C[Dependency overrides and locks]
  C --> D[Installed plugin workspace]
  D --> E[Compatibility checks]
  C --> F[Fixture security audit]
Loading

Technical review

Best possible solution:

Land the scoped dependency refresh through the existing fixture overrides and locks once required checks permit merging.

Do we have a high-confidence way to reproduce the issue?

Current-main locks establish the older dependency versions, and published artifacts verify the replacement versions; no installation or exploit reproduction was run during this review.

Is this the best way to solve the issue?

The existing override mechanism is the smallest complete repair for these mutable dependencies and preserves separately owned plugin artifacts and host selection.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against d1bfcf9157fb.

Provenance checked

Testing

Proof path: none.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 650a93d adds plugins/msteams/package.json:7 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 650a93d8c778; files: plugins/msteams/package.json)
  • Vincent Koc: Raw commit 0d36621 adds plugins/msteams/package.json:17 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 0d366214f0b3; files: plugins/msteams/package.json)

Labels

Label changes:

  • add P2: A bounded security dependency refresh for fixture workspaces, without evidence of active exploitation or an urgent broken user workflow.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: A bounded security dependency refresh for fixture workspaces, without evidence of active exploitation or an urgent broken user workflow.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 23, 2026, 8:10 PM ET / October 24, 2026, 00:10 UTC.

@steipete
steipete merged commit 0aa24e0 into main Oct 24, 2026
34 checks passed
@steipete
steipete deleted the fix/round16-security-followup branch October 24, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant