Repository navigation
build(deps): patch newly disclosed fixture vulnerabilities - #603
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates dependency overrides and locks for seven fixtures while preserving plugin versions, source references, and host pins. Example: Install the committed Microsoft Teams fixture.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: current main still contains the older dependencies, and this focused security refresh has no actionable findings. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherCrabpot fixture manifests and locks select npm dependency graphs for isolated plugin workspaces, which feed compatibility checks and the fixture-security gate. flowchart LR
A[Fixture configuration] --> B[Fixture package manifests]
B --> C[Dependency overrides and locks]
C --> D[Installed plugin workspace]
D --> E[Compatibility checks]
C --> F[Fixture security audit]
Technical reviewBest possible solution: Land the scoped dependency refresh through the existing fixture overrides and locks once required checks permit merging. Do we have a high-confidence way to reproduce the issue? Current-main locks establish the older dependency versions, and published artifacts verify the replacement versions; no installation or exploit reproduction was run during this review. Is this the best way to solve the issue? The existing override mechanism is the smallest complete repair for these mutable dependencies and preserves separately owned plugin artifacts and host selection. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against d1bfcf9157fb. Provenance checked
TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 23, 2026, 8:10 PM ET / October 24, 2026, 00:10 UTC. |
New advisories reached the registry between #602's successful audit and its post-merge run. Patch the mutable fixture dependencies for Zod, Undici, body-parser, and MSAL, covering 17 new alerts while retaining every reviewed plugin version, source ref, and host pin.
Teams needs MSAL Node 7.1.1 for the patched release. Its direct and Teams SDK consumers share that version; a synthetic client-credentials flow and Teams Apps import pass. Weixin retains its four-entry lock and the repository's existing legacy-peer-deps policy, avoiding an unintended host installation.
Validation: fresh Linux installs and dependency/security proof, exact patched-version assertions, HAPI's host/SDK/p-limit checks, MSAL synthetic authentication, and independent P0–P2 review. The final small Weixin lock also passed a local fresh install, schema check, and audit under nice 19. Documentation and the Unreleased changelog are updated.
The other 26 new alerts have verified publisher-bundle limitations: the latest tarballs still ship the affected bytes, which overrides cannot replace. Those alerts were separately dismissed with artifact-specific evidence. The security gate remains enabled.