Skip to content

chore(deps): refresh HTTP and ZIP dependencies - #1015

Merged
steipete merged 1 commit into
mainfrom
maint/round21-ocm
Nov 21, 2026
Merged

steipete merged 1 commit into
mainfrom
maint/round21-ocm

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

OCM's locked HTTP and ZIP dependencies miss current maintenance fixes. The HTTP patch fixes decoded response-size limits, exact-limit bodies, and fallback to another address after a NetworkDown error.

User Impact

Downloads receive those upstream HTTP fixes. ZIP handling moves to the current compatible minor release. Rust 1.88 support, the selected TLS roots, disabled default features, and OCM 0.3.9 stay unchanged.

Why This Change Was Made

Combines Dependabot #1012 (ureq 3.5.2) and #1013 (zip 9.5.1), including only the required transitive lockfile changes. No upgrade lifecycle or migration behavior changes.

Evidence

The complete Rust suite passed 2,069 tests on a disposable Linux worker using Node 24.22.1 and npm 11.19.1. Formatting, all-target compilation, 41 automatic-release policy tests, and five native-Gateway structural tests passed in the prescribed order. The installed binary and Rust 1.88 minimum check are covered by the same worker's final baseline. Independent P0–P2 review was clean.

The initial highly parallel library run encountered a transient ETXTBSY while executing a newly written fake service-manager script (601 passed, one failed). That exact test then passed five isolated runs; the complete suite passed with RUST_TEST_THREADS=2. No test assertion or product code was changed to obtain that result.

PR CI supplies the additional native macOS, Windows, and npm platform coverage. No real OCM/OpenClaw environment was stopped or modified.

@clawsweeper

clawsweeper Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:43:29.860141Z 572513f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 21, 2026
@clawsweeper

clawsweeper Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Updates ureq to 3.5.2 and zip to 9.5.1 with their required transitive dependencies and a changelog entry.

Example: OCM extracts the managed Node.js 24.22.1 Windows distribution.

  • Before: ZIP extraction uses zip 9.4.1.
  • After: The same extraction path uses zip 9.5.1.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The patch is focused and appears correct; proof currently rests on reported suite results and passing harness coverage, with broader platform tests unfinished.
Proof confidence 🦐 gold shrimp (3/6) This maintainer-authored maintenance PR is outside the contributor proof gate; supplied evidence consists of the reported remote suite and CI harness coverage, including Windows ZIP installation, rather than a standalone CLI download trace.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: OCM's locked HTTP and ZIP dependencies lag compatible upstream maintenance fixes.
Reason: The supplied maintainer-authored direction and prior merged refreshes support this narrow update while preserving existing product contracts.

Merge readiness

✅ Ready for maintainer review

This PR provides a useful dependency refresh that is absent from main; no actionable defect was found, and the Linux and macOS test jobs remain in progress.

Priority: P3
Reviewed head: 572513fbeab2d439b90966df7a9630a0186e47bf

Before merge

None.

Findings

None.

Agent review details

How this fits together

OCM's shared download and archive helpers consume HTTP responses and downloaded archives, producing metadata, verified artifact files, and extracted toolchains.

flowchart LR
  A[Runtime or toolchain setup] --> B[Shared HTTP client]
  B --> C[Downloaded artifact]
  C --> D[Checksum verification]
  D --> E[ZIP extraction]
  E --> F[Staged toolchain]
Loading

Technical review

Best possible solution:

Land the scoped dependency refresh once the existing required platform checks pass.

Do we have a high-confidence way to reproduce the issue?

This maintenance PR establishes no failing OCM reproduction; review inspected the dependency changes and existing coverage without running target code.

Is this the best way to solve the issue?

The lockfile refresh fits the existing version constraints and maintenance direction without adding another implementation or changing OCM configuration.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 96b10323bd10.

Provenance checked

  • Locked HTTP dependency keeps the original intent (f41dc3d: Refresh compatible runtime dependencies while retaining Rust 1.88, trusted certificate roots, and command behavior.)
  • Locked ZIP dependency keeps the original intent (6879db7: Advance zip to a compatible maintenance release.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned introduced change: The complete diff changes only the changelog and lockfile; dependency constraints, disabled default features, TLS configuration, and the OCM version remain unchanged. (Cargo.lock:1587, 572513fbeab2)
  • Current main still needs the update: The default branch remains at the pinned base, whose lockfile selects ureq 3.5.1 and zip 9.4.1. (Cargo.lock:1579, 96b10323bd10)
  • Production dependency boundary: OCM executes ureq through its shared HTTP agent and zip through ZipArchive; it already owns decoded JSON limits and performs ZIP extraction entry by entry. (src/infra/download.rs:196, 572513fbeab2)
  • Upstream HTTP change verified: The upstream comparison confirms decoded-body limit corrections and fallback to the next address after NetworkDown; OCM imports and executes this dependency. (src/unversioned/transport/tcp.rs:199, 51bb001154f4)
  • Required transitive additions verified: The upstream manifest makes constant_time_eq mandatory and enables zeroize derives, explaining the additional lockfile packages; inspected ZIP changes revealed no concrete regression in OCM's extraction path. (Cargo.toml:30, ee616771beda)
  • Candidate validation: Current-head formatting, Rust 1.88, Windows, and npm checks pass; the Windows job specifically passed managed Node ZIP installation and offline reuse, while Linux and macOS test jobs remain in progress. (.github/workflows/ci.yml:78, 572513fbeab2)

Likely related people:

  • Peter Steinberger: Raw commit f41dc3d adds Cargo.lock:1595 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f41dc3d316c6; files: Cargo.lock)
  • Shakker: Raw commit 72019bf adds Cargo.lock:721 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 72019bf30b9b; files: Cargo.lock)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Root-cause cluster

Relationship: canonical
Canonical: #1015
Summary: This PR consolidates the two separately proposed dependency updates.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

  • add P3: Compatible dependency maintenance with no established urgent OCM failure.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Compatible dependency maintenance with no established urgent OCM failure.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 20, 2026, 10:55 PM ET / November 21, 2026, 03:55 UTC.

@steipete
steipete merged commit f019833 into main Nov 21, 2026
15 checks passed
@steipete
steipete deleted the maint/round21-ocm branch November 21, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant