Repository navigation
Add an opt-in protected request exchange for Strands Box - #4007
freeqaz-openai wants to merge 7 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR adds an optional Rust sender that connects Strands Box requests to OCE’s existing signed Credential Proxy exchange. Example: A client sends POST /v1/responses with Authorization: Bearer oce-placeholder.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 5 items remain Keep this maintainer-authored draft open: it adds a useful reference sender, but the required regular Agent integration is deferred. Priority: P2 Before merge
Findings
Tests
Agent review detailsHow this fits togetherBox applies request policy and retains the client connection; the new sender exchanges signed authorization messages with OCC and sends one pinned HTTPS request to the provider. flowchart TB
Agent[Regular OCE Agent lifecycle] -. pending integration .-> Launcher[Native Box launcher]
Launcher --> Box[Box policy and client writer]
Client[Reference HTTPS client] --> Box
Box --> Sender[Protected sender]
Sender --> Authority[OCC Credential Proxy]
Sender --> Provider[Pinned HTTPS provider]
Authority --> Sender
Sender --> Box
Technical reviewBest possible solution: Connect the sender through the native Sandbox Driver’s regular Agent lifecycle and qualify its enrollment, isolation, withdrawal, and response-custody boundaries. Do we have a high-confidence way to reproduce the issue? This is a new capability; source inspection establishes the standalone reference path and the missing regular Agent caller, without executing target code. Is this the best way to solve the issue? Reusing the existing signed Credential Proxy exchange preserves its authorization owner, but the sender needs platform lifecycle integration to satisfy the repository’s delivery contract. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against aa2cfe543b3b. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: in-process harness. SecurityNeeds attention: The native descriptor handoff needs isolation evidence before its same-UID peer check can establish the intended supervisor boundary. EvidenceSecurity concerns:
What I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 28, 2026, 10:06 PM ET / October 29, 2026, 02:06 UTC. |
Add an opt-in Box reference sender for a bounded HTTPS model request. Box applies its policy and keeps the client connection; the OCE sender uses the existing Credential Proxy exchange to resolve material, request permission before the origin write, and check the response before handing it back to Box.
The reference includes a reproducible downstream Box source patch and a launcher for the hosted runtime. It does not enable protected mode for an installed Agent. Native execution enrollment, supervisor-only credential projection, and an installed no-bypass test are separate prerequisites.
A bounded Responses request from the OpenAI Node SDK 7.5.0 can use a public placeholder instead of a provider key. The sender drops the placeholder and SDK diagnostics and injects only the credential selected by OCE. Other authorization values and unsupported headers are refused before material lookup. Local checks cover withdrawal, a lost reply, replacement, and packaged startup refusal.