Skip to content

fix: read hook names from source host metadata - #123

Merged
steipete merged 1 commit into
mainfrom
fix/crabpot-hook-metadata
Oct 23, 2026
Merged

steipete merged 1 commit into
mainfrom
fix/crabpot-hook-metadata

Conversation

@steipete

@steipete steipete commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Current OpenClaw derives PluginHookName from its handler map and replaces PLUGIN_HOOK_NAMES with an exhaustive PLUGIN_HOOK_METADATA object. Inspector consequently reports zero hooks, and Crabpot's generated-surface check aborts after its corpus tests pass.

Read the explicit top-level metadata object with the existing TypeScript dependency. Preserve name-array hosts and reject computed/spread keys rather than returning a partial hook inventory. The parser never executes host code.

A failing regression reproduces the empty inventory; all 27 target-parser tests now pass, including comments, strings, nested declarations and unknown-key rejection. The failing canary source at 4f44cc7d7899cc924e7ce17cb0e399db8a72b6f7 now yields all 41 hooks. Independent P0–P2 review is clean. All 834 tests and package-content checks passed on AWS Crabbox. The exact failing Crabpot generated-surface command passed against the same host revision, with zero static or runtime missing registrations. Crabpot #597 adopts this source fix; PR CI is pending.

No package version change or publication.

@steipete
steipete requested a review from a team as a code owner October 23, 2026 03:11
@clawsweeper

clawsweeper Bot commented Oct 23, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T03:13:03.583257Z 23dc5dd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@steipete
steipete merged commit 6531cfc into main Oct 23, 2026
9 checks passed
@steipete
steipete deleted the fix/crabpot-hook-metadata branch October 23, 2026 03:16
steipete added a commit to openclaw/crabpot that referenced this pull request Oct 23, 2026
Restore development dashboard corpus checks by adopting the reviewed Inspector source fixes from openclaw/plugin-inspector#122 and openclaw/plugin-inspector#123. It removes implementation-only host imports while preserving inferred declarations, module augmentations and reference effects under the existing 2 GiB heap limit, and reads current OpenClaw hook metadata so generated-surface validation continues to work. Adopt the separately qualified published Inspector 0.4.4 update from #573.

Consolidate #575–#596 into 22 official plugin fallback updates to 2026.10.5 with verified publication/source identity. Patch Feishu and HAPI lock dependencies for follow-redirects, MCP SDK and Hono advisories. Preserve distinct host and legacy p-limit resolutions. Retain HAPI's documented missing-configuration blocker with Node's exact TypeScript warning and strict rejection of unrelated errors. Thanks @dependabot.

Proof: Linux reproduced the original heap exhaustion, then passed all six full-corpus assertions with the fix at the same heap limit; 834 Inspector tests, 12 focused host tests, 85 Crabpot tests, 50 manifest/diagnostic tests, 59-fixture source/packed/published smoke checks, 29 owned-lock security checks, and 22 publication verifications passed. Independent P0–P2 reviews are clean. The exact generated-surface check passed against the previously failing host revision. Full platform CI is recorded on this PR.

The Default Track host, fixture selectors, Windows ownership and budgets are unchanged. #305 remains with @vincentkoc. No release, tag, project version bump or manual deployment.
steipete added a commit that referenced this pull request Oct 27, 2026
Prepare the 0.4.5 patch release for the source-host heap-exhaustion fix (#122) and current hook metadata registry compatibility (#123).

Preserve all release notes and align package/lockfile versions. Validation: 14 focused release tests, npm tarball contents, independent P2 review, and exact-head CI. Publish only after the merged commit passes the release dry run and Crabpot source smoke.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant