Skip to content

refactor: consolidate report and capture implementations - #147

Merged
vincentkoc merged 3 commits into
mainfrom
refactor/structural-deduplication
Nov 4, 2026
Merged

vincentkoc merged 3 commits into
mainfrom
refactor/structural-deduplication

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Report sections, capture recording, registration export selection, and certificate declaration traversal repeat identical code.

Why This Change Was Made

Share the duplicated implementation through existing internal owners. Report rendering retains each renderer's escaping/padding and section order; hook recording retains argument shapes, capture indices, retained handlers, and fluent returns. Registration selection keeps its original precedence. Public exports and dependencies stay unchanged. Removes 67 net lines.

User Impact

No intended behavior change.

Evidence

  • 201 targeted test executions pass across report, inspector, capture, synthetic, and packed-certificate tests.
  • Both Markdown renderers match the original output for normal, empty, and escaped-cell reports.
  • Hook capture outputs, retention, index alignment, and fluent returns match the original with handler retention enabled and disabled.
  • Package contents validation passes.
  • Crabpot source smoke ran across 60 fixtures and reported the existing 83 corpus breakages.
  • Independent review found no contract changes.

@clawsweeper

clawsweeper Bot commented Nov 4, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 4, 2026 15:29
@vincentkoc
vincentkoc requested a review from a team as a code owner November 4, 2026 15:29
@vincentkoc
vincentkoc merged commit aae698c into main Nov 4, 2026
10 checks passed
@vincentkoc
vincentkoc deleted the refactor/structural-deduplication branch November 4, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant