Skip to content

chore: refresh dependencies used for Plugin Inspector checks - #159

Open
roboclaw-bot wants to merge 2 commits into
mainfrom
openclaw/deps-seven-day-plugin-inspector-nov21
Open

roboclaw-bot wants to merge 2 commits into
mainfrom
openclaw/deps-seven-day-plugin-inspector-nov21

Conversation

@roboclaw-bot

@roboclaw-bot roboclaw-bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Plugin Inspector’s automated checks and Crabbox hydration still use older patch releases of Node and older pnpm tooling. The lockfile also has an older compatible release of the ESTree type declarations used by the scope analyzer.

User Impact

User impact: No user-visible change or action required. The supported Node versions, inspector package version, and release workflow are unchanged.

Why This Change Was Made

Use the latest eligible patches on the existing Node 22 and 24 lines in CI and hydration, update hydration’s pnpm and pin its setup action to the exact release commit, and refresh the transitive ESTree types. All updates satisfy the inclusive 2026-11-14 01:46 UTC cutoff. No new runtime dependencies are added.

Evidence

A credential-free, network-isolated install passed the 939-test suite, package-contents guard, and 12 retained-import probes on Node 22. The matching npm install step did not rewrite the lockfile. All 21 focused SDK and failure-diagnostics tests passed on Node 24; the verified pnpm Linux artifact ran and the changed workflow files parsed. Windows and the publish-memory benchmark are left to normal PR CI; hydration and release workflows were not dispatched.

Version and age evidence
  • Node 22.23.5: released 2026-11-11; Linux and Windows artifacts last modified 11:03:40 and 11:55:03 UTC that day. Bundled npm 10.9.9 was published on 2026-07-29 at 17:56:50.421 UTC.
  • Node 24.22.3: released 2026-11-10; Windows and Linux artifacts last modified 2026-11-10 21:05:21 and 2026-11-11 00:42:29 UTC. Bundled npm 11.19.1 was published on 2026-08-26 at 21:47:53.323 UTC. Both local Linux binaries matched the upstream checksums.
  • pnpm 12.21.0: 2026-11-13 21:01:11.515 UTC; all 15 exact-version optional platform artifacts were published between 21:00:15.237 and 21:00:59.808 UTC. The package and the Linux executable matched npm’s SHA-512 integrity values.
  • pnpm/action-setup v6.1.1: GitHub release shown at 2026-11-03 13:50:23 UTC, at commit 73e46992. The native bootstrap lock pins pnpm 12.17.0 and 14 platform artifacts. All 15 integrity values matched the registry; the artifacts were published 2026-10-30 between 14:22:58.005 and 14:23:51.302 UTC.
  • @types/estree 1.0.10: 2026-10-29 04:34:27.999 UTC; its artifact matched npm’s SHA-512 integrity value and it adds no child dependencies. No other lockfile resolution changed.

Requested by @vincentkoc.

Work sessions

Linked for team reference; these sessions aren’t public.

Worked on by

roboclaw-bot and others added 2 commits November 21, 2026 03:07
Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
Worked on by:
- @vincentkoc

Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
OpenClaw-Publication: 89aaf492-9ce0-464f-af77-d10914e83077
@roboclaw-bot
roboclaw-bot requested a review from a team as a code owner November 21, 2026 03:07
@clawsweeper

clawsweeper Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 21, 2026
@clawsweeper

clawsweeper Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Updates CI Node patches, Crabbox pnpm tooling and its pinned setup action, and the transitive ESTree declarations.

Example: The Windows SDK workflow provisions Node before running its existing checks.

  • Before: It selects Node 22.23.4.
  • After: It selects Node 22.23.5.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, useful maintenance patch supported by successful exact-head workflow checks and no identified correctness or security defects.
Proof confidence 🐚 platinum hermit (4/6) This tooling-only change requires no shipped user-entry-point proof; exact-head workflow checks passed, while manual Crabbox hydration was explicitly not dispatched.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Development and validation workflows use older compatible tooling releases.
Reason: The authorized maintenance direction is narrowly implemented without changing public behavior, defaults, or supported runtime ranges.

Merge readiness

✅ Ready for maintainer review

Keep open: this PR provides a focused dependency refresh that is absent from main, with passing checks on the reviewed head and no actionable defects found.

Priority: P3
Reviewed head: 4775f4cb45ab5fc74157cc45051eea7a3656bf66

Before merge

None.

Findings

None.

Agent review details

How this fits together

GitHub workflows provision tooling and install the locked dependency graph, then produce compatibility-test and memory-benchmark results.

flowchart LR
  A[Repository revision] --> B[GitHub workflows]
  B --> C[Node and pnpm setup]
  C --> D[Dependency installation]
  D --> E[Tests and memory benchmarks]
  E --> F[Check results]
Loading

Technical review

Best possible solution:

Land the focused refresh through the existing workflows while preserving package contracts and supported Node versions.

Do we have a high-confidence way to reproduce the issue?

This is maintenance rather than a bug report; the pinned diff directly establishes the older tooling selected on main.

Is this the best way to solve the issue?

Updating the existing version selections and lockfile entry is the smallest complete change, with no additional production machinery or tests needed.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against a1c224e468dc.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned introduction: The introduced diff contains only version, action-reference, and matching lockfile integrity updates; main retains the older values. (4775f4cb45ab)
  • Repository policy applied: The full root policy was read; no nested policies or maintainer notes were present for these paths. Package behavior, entrypoints, release metadata, and version remain unchanged, so the conditional Crabpot followthrough requirement does not apply. (AGENTS.md:1, 4775f4cb45ab)
  • Exact-head validation: Node 22, Windows SDK entrypoints, Publish-time peak RSS, and security analysis checks succeeded on the reviewed head; the optional Proof check was skipped. (.github/workflows/check.yml:13, 4775f4cb45ab)
  • Executed dependency and immutable release identity: The hydration workflow executes this action, establishing its contract as relevant dependency evidence. The annotated v6.1.1 tag resolves to the exact pinned commit; its installer supports native pnpm 12 and the explicit version input. The dependency tree contains no AGENTS.md. (src/install-pnpm/run.ts:43, 73e46992e05b)
  • Security-related provenance: fix: generate CI with a Node patch that rejects compromised keys #121 selected fixed Node patches and native pnpm to reject compromised keys; this PR advances those existing version lines without restoring the earlier tooling. (.github/workflows/crabbox-hydrate.yml:33, 325f7068a94d)
  • Ownership history and local limit: Scoped history and current-main blame show shared ownership across CI, hydration, dependency updates, and memory gates. Following hydration history eventually encountered an unavailable older object; the current and changed base blobs were readable. (.github/workflows/crabbox-hydrate.yml, a1c224e468dc)

Likely related people:

  • Vincent Koc: Raw commit 7d69adb adds .github/workflows/crabbox-hydrate.yml:48 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 7d69adb8832e; files: .github/workflows/crabbox-hydrate.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: Routine tooling maintenance with no demonstrated user-facing regression or urgent operational impact.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine tooling maintenance with no demonstrated user-facing regression or urgent operational impact.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 20, 2026, 10:22 PM ET / November 21, 2026, 03:22 UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant