Skip to content

fix: read raw packed plugin manifest fields - #57

Merged
obviyus merged 1 commit into
mainfrom
agent/fix-packed-manifest-fields
Aug 5, 2026
Merged

obviyus merged 1 commit into
mainfrom
agent/fix-packed-manifest-fields

Conversation

@obviyus

@obviyus obviyus commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Read raw PluginManifest fields from packed OpenClaw declarations.
  • Add regression coverage distinguishing raw uiHints from runtime configUiHints.

Proof

  • New regression fails on origin/main: actual fields are configUiHints, id, rootDir; expected raw fields include configSchema, contracts, id, uiHints.
  • Same regression passes on this branch.
  • Composio exact-version validation changes from 1 warning to 0 warnings.
  • npm run release:contents and git diff --check pass.

npm test passes 235/236; the remaining TypeScript import-classification failure reproduces on clean origin/main under Node 26.

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal priority bug or improvement with limited blast radius. labels Aug 4, 2026
@clawsweeper

clawsweeper Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge. Reviewed August 5, 2026, 1:55 AM ET / 05:55 UTC.

ClawSweeper review

What this changes

The PR makes packed OpenClaw target parsing read the public raw PluginManifest fields instead of runtime registry fields and adds a regression test for uiHints.

Regression provenance

Possible regression — suspected (reviewed change). No predecessor PR is attributed.

Merge readiness

⛔ Blocked until real behavior proof is added - 5 items remain

Keep open: the branch targets a source-proven packed-target compatibility bug, but it still needs the required Crabpot smoke and inspectable real behavior proof before merge.

Priority: P2
Reviewed head: 6400db8e93a53559d532fd9e3fe30321a984c231

Review scores

Measure Result What it means
Overall readiness 🧂 unranked krab (1/6) The core fix is focused, but missing real packed-target proof and the unresolved repository validation requirements make it not merge-ready.
Proof confidence 🧂 unranked krab (1/6) Needs real behavior proof before merge: The body states test and Composio results, but it supplies no inspectable after-fix packed-target output or Crabpot smoke transcript; post redacted live evidence before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality 🦐 gold shrimp (3/6) 2 actionable review findings remain.

Verification

Check Result Evidence
Real behavior Needs proof Needs real behavior proof before merge: The body states test and Composio results, but it supplies no inspectable after-fix packed-target output or Crabpot smoke transcript; post redacted live evidence before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed 4 items Current-main defect: The packed-target parser on current main reads PluginManifestRecord, although field coverage reports whether plugin metadata exists in the public PluginManifest contract; the branch changes that selector and parser target.
Focused regression coverage: The branch adds a packed declaration fixture containing both raw and runtime record types and asserts that configSchema, contracts, id, and uiHints are reported as supported raw fields.
Feature provenance: Blame and string history trace the current packed-target selector to the v0.3.20 compatibility work, which is also the latest released baseline.
Findings 2 actionable findings [P2] Remove the release-owned changelog entry
[P2] Run the required Crabpot plugin-inspector smoke
Security None None.

How this fits together

Plugin Inspector reads an OpenClaw checkout or installed package to learn supported plugin-manifest fields, then compares those fields with plugin metadata. For packed targets, this parser feeds compatibility warnings consumed by CLI and Crabpot reports.

flowchart LR
A[Plugin manifest metadata] --> D[Field comparison]
B[Packed OpenClaw declarations] --> C[Declaration parser]
C --> D
D --> E[Compatibility warnings]
E --> F[CLI and Crabpot reports]
Loading

Before merge

  • Add real behavior proof - Needs real behavior proof before merge: The body states test and Composio results, but it supplies no inspectable after-fix packed-target output or Crabpot smoke transcript; post redacted live evidence before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • Remove the release-owned changelog entry (P2) - Release notes are release-owned for this repository workflow. Please remove this entry from the PR; use the PR body or commit message for release context instead.
  • Run the required Crabpot plugin-inspector smoke (P2) - This changes plugin-inspector behavior, so AGENTS.md requires the Crabpot plugin-inspector smoke before completion. The current body has no inspectable smoke transcript; run the source-mode smoke against this head and post redacted output.
  • Resolve merge risk (P1) - Changing the declaration source changes compatibility warnings for all packed OpenClaw targets; without the required Crabpot smoke and inspectable packed-target output, downstream warning behavior remains unverified.
  • Complete next step (P2) - Hold automerge until the contributor supplies the required real packed-target and Crabpot smoke proof, removes the release-owned entry, and a human reviews the refreshed evidence.

Findings

  • [P2] Remove the release-owned changelog entry — CHANGELOG.md:8
  • [P2] Run the required Crabpot plugin-inspector smoke — src/openclaw-target.js:287-293
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Diff footprint production +2/-2, tests +38, release metadata +1 The implementation is small and regression-focused, while the unrelated release-owned entry should not ship with this PR.

Merge-risk options

Maintainer options:

  1. Validate packed-target compatibility before merge (recommended)
    Remove the release-owned changelog entry and post redacted before/after packed-target output plus the required Crabpot source-mode smoke transcript.
  2. Pause pending external-consumer proof
    Keep the PR open but unmerged if the packed-target and Crabpot validation cannot be reproduced against the proposed head.

Technical review

Best possible solution:

Land the narrow public-PluginManifest parser fix with its regression test after removing the release-owned changelog entry and providing redacted packed-target and Crabpot smoke evidence.

Do we have a high-confidence way to reproduce the issue?

Yes—source inspection gives a high-confidence reproduction shape: a packed declaration file containing both PluginManifest and PluginManifestRecord makes current main report runtime-only fields, while the branch's focused regression asserts the public fields.

Is this the best way to solve the issue?

Yes—the raw public PluginManifest selector is the narrow maintainable repair; it should be validated against a real packed target and Crabpot before merge.

Full review comments:

  • [P2] Remove the release-owned changelog entry — CHANGELOG.md:8
    Release notes are release-owned for this repository workflow. Please remove this entry from the PR; use the PR body or commit message for release context instead.
    Confidence: 0.98
  • [P2] Run the required Crabpot plugin-inspector smoke — src/openclaw-target.js:287-293
    This changes plugin-inspector behavior, so AGENTS.md requires the Crabpot plugin-inspector smoke before completion. The current body has no inspectable smoke transcript; run the source-mode smoke against this head and post redacted output.
    Confidence: 0.97

Overall correctness: patch is incorrect
Overall confidence: 0.93

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against c61aeb8890bd.

Labels

Label justifications:

  • P2: This is a bounded compatibility-reporting defect that can produce false unknown-field warnings for packed targets.
  • merge-risk: 🚨 compatibility: Selecting a different manifest contract changes which metadata existing packed-target users are told is supported.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.

Evidence

What I checked:

  • Current-main defect: The packed-target parser on current main reads PluginManifestRecord, although field coverage reports whether plugin metadata exists in the public PluginManifest contract; the branch changes that selector and parser target. (src/openclaw-target.js:287, c61aeb8890bd)
  • Focused regression coverage: The branch adds a packed declaration fixture containing both raw and runtime record types and asserts that configSchema, contracts, id, and uiHints are reported as supported raw fields. (test/openclaw-target.test.js:178, 6400db8e93a5)
  • Feature provenance: Blame and string history trace the current packed-target selector to the v0.3.20 compatibility work, which is also the latest released baseline. (src/openclaw-target.js:287, 718b5aa8a4c8)
  • Repository validation policy: This behavior change requires a Crabpot plugin-inspector smoke before it can be called complete; the PR body lists package-content and test claims but no Crabpot smoke transcript or inspectable live target output. (AGENTS.md:12, c61aeb8890bd)

Likely related people:

  • Patrick Erichsen: The current selector and packed-target reader trace to the v0.3.20 compatibility change. (role: introduced packed-target parsing; confidence: high; commits: 718b5aa8a4c8; files: src/openclaw-target.js)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Remove the CHANGELOG.md entry.
  • Post a redacted terminal transcript showing current-main failure and branch success against a packed target.
  • Run and post the required Crabpot source-mode plugin-inspector smoke result.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (6 earlier review cycles)
  • reviewed 2026-08-04T12:02:51.784Z sha 6400db8 :: needs maintainer review before merge. :: none
  • reviewed 2026-08-04T12:26:04.977Z sha 6400db8 :: needs real behavior proof before merge. :: none
  • reviewed 2026-08-04T14:08:14.961Z sha 6400db8 :: needs real behavior proof before merge. :: [P2] Remove the release-owned changelog entry
  • reviewed 2026-08-04T18:21:54.802Z sha 6400db8 :: needs real behavior proof before merge. :: [P2] Remove the release-owned changelog entry
  • reviewed 2026-08-04T21:03:31.524Z sha 6400db8 :: needs real behavior proof before merge. :: [P2] Remove the release-owned changelog entry
  • reviewed 2026-08-05T04:02:51.561Z sha 6400db8 :: needs real behavior proof before merge. :: [P2] Remove the release-owned changelog entry | [P2] Run the required Crabpot plugin-inspector smoke

@obviyus
obviyus marked this pull request as ready for review August 4, 2026 12:23
@obviyus
obviyus requested a review from a team as a code owner August 4, 2026 12:23
@obviyus

obviyus commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@clawsweeper automerge

@clawsweeper

clawsweeper Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

🦞🧹
ClawSweeper automerge is enabled.

  • Head: 6400db8e93a5
  • Label: clawsweeper:automerge
  • Action: exact-head review queued (workflow sweep.yml, event repository_dispatch).
  • Flow: review this head, repair/rebase only if needed, then re-review the exact repaired head before merge.

Draft PRs stay fix-only until GitHub marks them ready for review. Pause with /clawsweeper stop.

Automerge progress:

  • 2026-08-04 12:23:49 UTC review queued 6400db8e93a5 (queued)

Re-review progress:

@obviyus obviyus self-assigned this Aug 4, 2026
@clawsweeper clawsweeper Bot added clawsweeper:automerge Maintainer opted this ClawSweeper PR into bounded ClawSweeper-reviewed automerge rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. clawsweeper:human-review ClawSweeper automerge is paused for maintainer review and removed proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 4, 2026
@clawsweeper

clawsweeper Bot commented Aug 4, 2026

Copy link
Copy Markdown

🦞✅
ClawSweeper is pausing this repair loop for human review.

Source: clawsweeper[bot]
Reason: - [ ] Add real behavior proof - Needs stronger real behavior proof before merge: The PR describes local regression and Composio results but does not include inspectable output from the repository-required Crabpot pl... (sha=6400db8e93a53559d532fd9e3fe30321a984c231)

Why human review is needed:
ClawSweeper found a blocker that should be resolved or accepted by a maintainer before the repair or automerge loop continues.

What the maintainer can do as a next step:
If the maintainer accepts the current risk and wants ClawSweeper to continue merge gates, comment @clawsweeper approve. If more work is needed, resolve the blocker first, then comment @clawsweeper automerge to re-review and continue. If automation should stay paused, leave clawsweeper:human-review in place or comment @clawsweeper stop.

I added clawsweeper:human-review and left the final call with a maintainer.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Aug 4, 2026
@obviyus
obviyus merged commit 7c2d11a into main Aug 5, 2026
22 checks passed
@obviyus
obviyus deleted the agent/fix-packed-manifest-fields branch August 5, 2026 06:29
@obviyus

obviyus commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Landed via squash onto main.

  • Scoped tests: node --test --test-name-pattern "packed OpenClaw target parser reads raw manifest fields" test/openclaw-target.test.js, npm run release:contents, git diff --check
  • Regression proof: the new test failed on the base and passed on the PR; Composio validation changed from one warning to zero.
  • Changelog: CHANGELOG.md updated
  • Land commit: 6400db8e93a53559d532fd9e3fe30321a984c231
  • Merge commit: 7c2d11af887e8a63ac13d9e88f58628c6f8d5583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clawsweeper:automerge Maintainer opted this ClawSweeper PR into bounded ClawSweeper-reviewed automerge clawsweeper:human-review ClawSweeper automerge is paused for maintainer review merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant