Repository navigation
fix: read raw packed plugin manifest fields - #57
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed August 5, 2026, 1:55 AM ET / 05:55 UTC. ClawSweeper reviewWhat this changesThe PR makes packed OpenClaw target parsing read the public raw PluginManifest fields instead of runtime registry fields and adds a regression test for uiHints. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked until real behavior proof is added - 5 items remain Keep open: the branch targets a source-proven packed-target compatibility bug, but it still needs the required Crabpot smoke and inspectable real behavior proof before merge. Priority: P2 Review scores
Verification
How this fits togetherPlugin Inspector reads an OpenClaw checkout or installed package to learn supported plugin-manifest fields, then compares those fields with plugin metadata. For packed targets, this parser feeds compatibility warnings consumed by CLI and Crabpot reports. flowchart LR
A[Plugin manifest metadata] --> D[Field comparison]
B[Packed OpenClaw declarations] --> C[Declaration parser]
C --> D
D --> E[Compatibility warnings]
E --> F[CLI and Crabpot reports]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the narrow public-PluginManifest parser fix with its regression test after removing the release-owned changelog entry and providing redacted packed-target and Crabpot smoke evidence. Do we have a high-confidence way to reproduce the issue? Yes—source inspection gives a high-confidence reproduction shape: a packed declaration file containing both PluginManifest and PluginManifestRecord makes current main report runtime-only fields, while the branch's focused regression asserts the public fields. Is this the best way to solve the issue? Yes—the raw public PluginManifest selector is the narrow maintainable repair; it should be validated against a real packed target and Crabpot before merge. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c61aeb8890bd. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (6 earlier review cycles)
|
|
@clawsweeper automerge |
|
🦞🧹
Draft PRs stay fix-only until GitHub marks them ready for review. Pause with Automerge progress:
Re-review progress:
|
|
🦞✅ Source: Why human review is needed: What the maintainer can do as a next step: I added |
|
Landed via squash onto main.
|
Summary
PluginManifestfields from packed OpenClaw declarations.uiHintsfrom runtimeconfigUiHints.Proof
origin/main: actual fields areconfigUiHints,id,rootDir; expected raw fields includeconfigSchema,contracts,id,uiHints.npm run release:contentsandgit diff --checkpass.npm testpasses 235/236; the remaining TypeScript import-classification failure reproduces on cleanorigin/mainunder Node 26.