Skip to content

improve(test): reduce delivery cycle fixture setup - #332

Merged
vincentkoc merged 1 commit into
mainfrom
improve/batch-delivery-cycle-fixture
Nov 20, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
improve/batch-delivery-cycle-fixture

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

What Problem This Solves

The delivery-cycle CLI test creates 501 synthetic messages with one SQLite transaction per message before exercising capture and resume behavior. This repeats transaction setup unnecessarily.

User Impact

No user-visible change. Developers run the delivery-cycle test with less fixture setup.

Why This Change Was Made

Use the existing ordered batch writer and assert the full written count. Each helper call still commits before capture or delivery begins. The subsequent single-message updates and existing resume, retry, cancellation, baseline, and output checks remain intact. Production code is unchanged.

Evidence

  • Independent P0–P3 review: scoped-clean.
  • Five interleaved local target pairs passed: median 0.807s before, 0.507s after, about 37% lower. Absolute timings varied and one pair regressed; this does not establish a whole-suite or hosted speedup.
  • Full CLI package, scoped vet, and formatting checks passed with CGO disabled on macOS.
  • Full hosted CI passed, including Linux race tests, native macOS tests, lint, dependency checks, and snapshot packaging. Docker, CodeQL, and secret scanning passed. Local native/race execution was unavailable because the Xcode license is unaccepted.

@clawsweeper

clawsweeper Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@github-actions github-actions Bot added the other label Nov 20, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review November 20, 2026 06:16
@vincentkoc
vincentkoc merged commit 72aeadb into main Nov 20, 2026
21 of 22 checks passed
@vincentkoc
vincentkoc deleted the improve/batch-delivery-cycle-fixture branch November 20, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant