Repository navigation
fix(cli): show command help with malformed config - #333
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
After cloud-mode routing was added, command help failed whenever an existing config file contained malformed TOML. For example,
slacrawl --config broken.toml sync --helpreported a config parse error instead of showing usage.User Impact
People can read command help while repairing a broken config. Commands that need configuration still report their own validation errors, and valid cloud configs still reject unsupported local commands before side effects.
Why This Change Was Made
Keep the early refusal for successfully loaded cloud configuration, but leave config-load errors to each command after its flag parser runs. This restores the existing help and argument precedence without scanning arguments for help-like values. A regression test verifies that cloud-mode init, sync, publish, and users neither rewrite config nor create a local archive. The SDK upgrade check also now expects the new explicit local-mode defaults while preserving its historical v0.10.6 input and exact comparison of the saved configuration.
Evidence