Repository navigation
improve(matches): update cached matches individually and build snapshots on read - #107
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 20, 2026 12:17
…-transitions * origin/main: improve(ci): prioritize the latest main commit (#109) improve(ci): stop the PR matrix after a package check fails (#105) improve(ci): avoid reinstalling pnpm after bootstrap (#101) fix(loading): ignore obsolete preload redirects after revalidation (#102) fix(router): honor a subscriber stopping a pending or redirecting navigation (#104) refactor(tests): verify load sharing and cache deadlines with smaller fixtures (#106) fix(history): resolve generated paths on startup with repeated base slashes (#103) improve(ci): run workflow lint when its inputs change (#100) # Conflicts: # CHANGELOG.md # src/router.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Warming one more route made the router walk the existing cache, even when nobody was reading router state.
User Impact
Preloads and navigation update one match at a time. Callers still receive match lists in the same order, and previously read snapshots remain stable.
Why This Change Was Made
The store now replaces the active or pending match by key and updates individual cache entries. It builds the three snapshot arrays together on the next state read. Each notification still reaches state subscribers before match subscribers.
Evidence
pnpm run checkpassed all 73 tests and package import validation. The public declarations matched the updated baseline byte for byte.